From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:59512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbeLCSnX (ORCPT ); Mon, 3 Dec 2018 13:43:23 -0500 Date: Mon, 3 Dec 2018 13:43:13 -0500 From: Sasha Levin To: Dinh Nguyen Cc: stable@vger.kernel.org, gregkh@linuxfoundation.org, Philipp Zabel Subject: Re: [PATCH for v4.9-stable] reset: make optional functions really optional Message-ID: <20181203184310.GN235790@sasha-vm> References: <20181203173029.18549-1-dinguyen@kernel.org> <20181203174422.GM235790@sasha-vm> <7c56aa7e-f86c-e1d8-ad65-ca35c287ce75@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <7c56aa7e-f86c-e1d8-ad65-ca35c287ce75@kernel.org> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Dec 03, 2018 at 12:31:59PM -0600, Dinh Nguyen wrote: > > >On 12/3/18 11:44 AM, Sasha Levin wrote: >> On Mon, Dec 03, 2018 at 11:30:29AM -0600, Dinh Nguyen wrote: >>> From: Ramiro Oliveira >>> >>> commit bb475230b8e59a547ab66ac3b02572df21a580e9 upstream. >>> >>> The *_get_optional_* functions weren't really optional so this patch >>> makes them really optional. >>> >>> These *_get_optional_* functions will now return NULL instead of an error >>> if no matching reset phandle is found in the DT, and all the >>> reset_control_* functions now accept NULL rstc pointers. >>> >>> Signed-off-by: Ramiro Oliveira >>> Signed-off-by: Philipp Zabel >>> --- >>> Please apply to v4.9.y stable tree. >> >> The original commit had a few upstream fixes: >> >> bb6c7768385b reset: remove remaining WARN_ON() in >> 1554bbd4ad40 reset: make device_reset_optional() really optional >> 62e24c5775ec reset: add exported __reset_control_get, return NULL if >> optional >> 0ca10b60ceeb reset: fix optional reset_control_get stubs to return NULL >> 4891486fb2c8 reset: core: fix reset_control_put >> >> We'll need to backport them to 4.9 as well if you backport this commit. >> > >Hmm..I was able to fix an ethernet driver load issue by just backporting >this patch. Should I investigate backport of the other patches as well? That patch will probably work on it's own, but if there are fixes for it then they should be backported as well. -- Thanks, Sasha