From: Sasha Levin <sashal@kernel.org>
To: Dexuan Cui <decui@microsoft.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"apw@canonical.com" <apw@canonical.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Stephen Hemminger <sthemmin@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>
Subject: Re: [PATCH] [REPOST for the char-misc-linus branch] Drivers: hv: vmbus: Offload the handling of channels to two workqueues
Date: Tue, 4 Dec 2018 03:57:34 -0500 [thread overview]
Message-ID: <20181204085734.GQ235790@sasha-vm> (raw)
In-Reply-To: <PU1P153MB01696ADED4633CB6B627ACA2BFAE0@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
On Mon, Dec 03, 2018 at 08:11:18PM +0000, Dexuan Cui wrote:
>> From: Sasha Levin <sashal@kernel.org>
>> Sent: Monday, December 3, 2018 6:16 AM
>>
>> Hi,
>>
>> [This is an automated email]
>>
>> This commit has been processed because it contains a "Fixes:" tag,
>> fixing commit: 8195b1396ec8 hv_netvsc: fix deadlock on hotplug.
>>
>> The bot has tested the following trees: v4.19.6, v4.14.85,
>>
>> v4.19.6: Build OK!
>> v4.14.85: Failed to apply! Possible dependencies:
>> 50229128727f ("Drivers: hv: vmbus: Fix the offer_in_progress in
>> vmbus_process_offer()")
>> c2e5df616e1a ("vmbus: add per-channel sysfs info")
>>
>> How should we proceed with this patch?
>> Sasha
>
>BTW, the patch went into char-misc.git's char-misc-linus branch 13 hours ago:
>37c2578c0c40 ("Drivers: hv: vmbus: Offload the handling of channels to two workqueues")
>
>linux-4.14.y (v4.14.85) lacks c2e5df616e1a ("vmbus: add per-channel sysfs info")
>and the other related patches so this patch can't apply cleanly.
>
>I suggest we cherry-pick all the related patches to linux-4.14.y in this order:
>
>(Note: 37c2578c0c40 is in char-misc.git's char-misc-linus branch and is not in Linus's tree yet)
>
>c2e5df616e1a ("vmbus: add per-channel sysfs info")
>869b5567e12f ("vmbus: unregister device_obj->channels_kset")
>6712cc9c2211 ("vmbus: don't return values for uninitalized channels")
>50229128727f ("Drivers: hv: vmbus: Fix the offer_in_progress in vmbus_process_offer()")
>37c2578c0c40 ("Drivers: hv: vmbus: Offload the handling of channels to two workqueues")
>
>
>Alternatively, we can skip c2e5df616e1a ("vmbus: add per-channel sysfs info"), and then
>please use the attached rebased patch for v4.14.85.
>
>
>I prefer the first solution.
Why is c2e5df616e1a needed on 4.14? We usually prefer to take a
dependency or two to avoid custom backports, but a sysfs ABI change
which causes only trivial conflicts for the actual fix is a bit too
much.
--
Thanks,
Sasha
next prev parent reply other threads:[~2018-12-04 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <PU1P153MB0169DBC552AEAB82665E8B8EBFAE0@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
[not found] ` <20181203141604.7FED32082F@mail.kernel.org>
2018-12-03 20:11 ` [PATCH] [REPOST for the char-misc-linus branch] Drivers: hv: vmbus: Offload the handling of channels to two workqueues Dexuan Cui
2018-12-04 8:57 ` Sasha Levin [this message]
2018-12-04 9:05 ` Dexuan Cui
2018-12-11 14:09 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204085734.GQ235790@sasha-vm \
--to=sashal@kernel.org \
--cc=apw@canonical.com \
--cc=decui@microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=stable@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox