Re: + panic-avoid-the-extra-noise-dmesg.patch added to -mm tree

Feng Tang
2018-12-05T02:47:13Z

Hi Sergey,

On Wed, Dec 05, 2018 at 11:26:54AM +0900, Sergey Senozhatsky wrote:
> On (12/04/18 23:49), Feng Tang wrote:
> > This should be able to achieve the same goal.
> >
> > One thing I can think of is what mentioned by Sergey that some sysrq
> > handler may want to print out something, but it should mostly be
> > covered by 2 other panic debug print patches, which will print out
> > task/mem/timer/lock/ftrace info runtime on demand.
>
> Well, not all sysrq handlers just printk stuff; some do sane things,
> like emergency sync, umount, etc.

Yes, I understand. I said that by assuming we will keep the irq enabled and
use the panic_blinking to control the flag, as suggested by Petr and you.

With irq enabled, these sync, umount will be completed as usual.

Btw, just FYI, I just tried the sysrq (using minicom CTL + A + F + 'magic key'),
it works with system is running, but failed after I trigger a panic, I will
check more though I'm not very familiar with sysrq yet.

Thanks,
Feng