From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Iwpa=OO=gmail.com=sergey.senozhatsky.work@kernel.org>
Date: Wed, 5 Dec 2018 12:05:55 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Feng Tang <feng.tang@intel.com>
Cc: Petr Mladek <pmladek@suse.com>, akpm@linux-foundation.org, bp@suse.de,
	keescook@chromium.org, mm-commits@vger.kernel.org,
	sergey.senozhatsky@gmail.com, stable@vger.kernel.org,
	tglx@linutronix.de, Steven Rostedt <rostedt@goodmis.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Sasha Levin <sashal@kernel.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: + panic-avoid-the-extra-noise-dmesg.patch added to -mm tree
Message-ID: <20181205030555.GA19842@jagdpanzerIV>
References: <20181204071531.z62N9NwXC%akpm@linux-foundation.org>
 <20181204102033.ltdvc7gmev2gvlkq@pathway.suse.cz>
 <20181204154936.wbgcovzpc54n6dvs@shbuild888>
 <20181204160152.375vymcau4lnejx4@pathway.suse.cz>
 <20181205015338.djdmnph4nrw3ua6u@shbuild888>
 <20181205025057.GB503@jagdpanzerIV>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181205025057.GB503@jagdpanzerIV>
List-ID: <stable.vger.kernel.org>

On (12/05/18 11:50), Sergey Senozhatsky wrote:
> 
> panic_print_sys_info() can be very verbose, and it happens much later
> than dump_stack() from panic CPU. So you are guaranteed to have same
> problems you are trying to avoid: "the original context gets
> lost on screen" and "confused people post bad bug reports".
> 

And it probably would be _a bit_ better to do panic_print_sys_info()
before console_flush_on_panic().

---
        debug_locks_off();
-       console_flush_on_panic();
-
        panic_print_sys_info();
+       console_flush_on_panic();
---

	-ss