From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com ([66.111.4.25]:56969 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727575AbeLFKEg (ORCPT ); Thu, 6 Dec 2018 05:04:36 -0500 Date: Thu, 6 Dec 2018 11:04:29 +0100 From: Greg KH To: Krzysztof Kozlowski Cc: stable@vger.kernel.org, Wei Yongjun , Jacek Anaszewski Subject: Re: [PATCH stable v4.4+ 3/3] leds: leds-gpio: Fix return value check in create_gpio_led() Message-ID: <20181206100429.GA11518@kroah.com> References: <1544089622-23982-1-git-send-email-krzk@kernel.org> <1544089622-23982-3-git-send-email-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1544089622-23982-3-git-send-email-krzk@kernel.org> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Dec 06, 2018 at 10:47:02AM +0100, Krzysztof Kozlowski wrote: > From: Wei Yongjun > > commit 2d88a331e48095cf60ad9bdf3177bd401bf99727 upstream. > > In case of error, the function gpio_to_desc() returns NULL > pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test. > > Signed-off-by: Wei Yongjun > Signed-off-by: Jacek Anaszewski > Signed-off-by: Krzysztof Kozlowski > --- > drivers/leds/leds-gpio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > All 3 now queued up, thanks. greg k-h > diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c > index 5db4515a4fd7..df186b38da78 100644 > --- a/drivers/leds/leds-gpio.c > +++ b/drivers/leds/leds-gpio.c > @@ -118,8 +118,8 @@ static int create_gpio_led(const struct gpio_led *template, > return ret; > > led_dat->gpiod = gpio_to_desc(template->gpio); > - if (IS_ERR(led_dat->gpiod)) > - return PTR_ERR(led_dat->gpiod); > + if (!led_dat->gpiod) > + return -EINVAL; > } > > led_dat->cdev.name = template->name; > -- > 2.7.4 >