Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Erick Cafferata <erick@cafferata.me>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>,
	Mike Rapoport <rppt@linux.vnet.ibm.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Subject: Re: x86: e820 regression
Date: Mon, 10 Dec 2018 11:58:31 -0500	[thread overview]
Message-ID: <20181210165831.GA97256@sasha-vm> (raw)
In-Reply-To: <20181210142151.xme3ncueelvi3xfa@YUKI.localdomain>

On Mon, Dec 10, 2018 at 09:21:52AM -0500, Erick Cafferata wrote:
>On 12/10 10:49, Greg KH wrote:
>> On Mon, Dec 10, 2018 at 08:54:21AM +0000, Naoya Horiguchi wrote:
>> > Hi Erick,
>> >
>> > On Mon, Dec 10, 2018 at 03:28:37AM -0500, Erick Cafferata wrote:
>> > > The following commit introduced a regression on my system.
>> > >
>> > > 124049decbb121ec32742c94fb5d9d6bed8f24d8
>> > > x86/e820: put !E820_TYPE_RAM regions into memblock.reserved
>> > >
>> > > and it was backported to stable, stopping the kernel to boot on my system since around 4.17.4.
>> > > It was reverted on upstream a couple months ago.
>> > > commit 2a5bda5a624d6471d25e953b9adba5182ab1b51f upstream
>> >
>> > This commit seems not a correct pointer.
>> > In mainline, commit 124049decbb was reverted by
>> >
>> >     commit 9fd61bc95130d4971568b89c9548b5e0a4e18e0e
>> >     Author: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
>> >     Date:   Fri Oct 26 15:10:24 2018 -0700
>> >
>> >         Revert "x86/e820: put !E820_TYPE_RAM regions into memblock.reserved"
>> >
>> > and, the original problem was finally fixed by
>> >
>> >     commit 907ec5fca3dc38d37737de826f06f25b063aa08e
>> >     Author: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>> >     Date:   Fri Oct 26 15:10:15 2018 -0700
>> >
>> >         mm: zero remaining unavailable struct pages
>> >
>> >         Patch series "mm: Fix for movable_node boot option", v3.
>> >
>> > so I think both patches should be backported onto v4.17.z.
>>
>> 4.17.y and 4.18.y are long end-of-life, there's nothing I can do there.
>>
>> I can apply the above patches to the 4.19.y tree, is that sufficient?
>>
>> thanks,
>>
>> greg k-h
>If it were possible to backport it to 4.14 as well. It would be better,
>but 4.19 is already good.
>Also, would you port only the revert commit, or also the correct fix for
>the previous issue?
>
>PD: also, as it was pointed out previously, the correct commit is
>9fd61bc95130d4971568b89c9548b5e0a4e18e0e.
>PD2: sorry about removing the context in the previous mail.

9fd61bc95130d4971568b89c9548b5e0a4e18e0e looks like the commit that
reverts the patch in question, not an additional fix.

--
Thanks,
Sasha

  reply	other threads:[~2018-12-10 16:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-10  8:28 x86: e820 regression Erick Cafferata
2018-12-10  8:54 ` Naoya Horiguchi
2018-12-10  9:49   ` Greg KH
2018-12-10  9:58     ` Naoya Horiguchi
2018-12-10 13:39     ` Erick Cafferata
2018-12-10 13:47       ` Greg KH
2018-12-10 14:21     ` Erick Cafferata
2018-12-10 16:58       ` Sasha Levin [this message]
2018-12-10 17:15         ` Erick Cafferata
2018-12-10 23:10           ` Sasha Levin
2018-12-11  0:01             ` Erick Cafferata
2018-12-11  0:39               ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181210165831.GA97256@sasha-vm \
    --to=sashal@kernel.org \
    --cc=erick@cafferata.me \
    --cc=gregkh@linuxfoundation.org \
    --cc=m.mizuma@jp.fujitsu.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox