* [PATCH] USB: serial: option: add HP lt4132 @ 2018-12-08 18:05 Tore Anderson 2018-12-09 15:21 ` Sasha Levin 2018-12-10 9:06 ` Johan Hovold 0 siblings, 2 replies; 6+ messages in thread From: Tore Anderson @ 2018-12-08 18:05 UTC (permalink / raw) To: Johan Hovold, Greg Kroah-Hartman, linux-usb, linux-kernel Cc: Tore Anderson, stable The HP lt4132 is a rebranded Huawei ME906s-158 LTE modem. The interface with protocol 0x16 is "CDC ECM & NCM" according to the *.inf files included with the Windows driver. Attaching the option driver to it doesn't result in a /dev/ttyUSB* device being created, so I've excluded it. Note that it is also excluded for corresponding Huawei-branded devices, cf. commit d544db293a44a. T: Bus=01 Lev=01 Prnt=01 Port=02 Cnt=02 Dev#= 3 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=ff MxPS=64 #Cfgs= 3 P: Vendor=03f0 ProdID=a31d Rev=01.02 S: Manufacturer=HP Inc. S: Product=HP lt4132 LTE/HSPA+ 4G Module S: SerialNumber=0123456789ABCDEF C: #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=2mA I: If#=0x0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=06 Prot=10 Driver=option I: If#=0x1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=13 Driver=option I: If#=0x2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=12 Driver=option I: If#=0x3 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=06 Prot=16 Driver=(none) I: If#=0x4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=14 Driver=option I: If#=0x5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=1b Driver=option T: Bus=01 Lev=01 Prnt=01 Port=02 Cnt=02 Dev#= 3 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=ff MxPS=64 #Cfgs= 3 P: Vendor=03f0 ProdID=a31d Rev=01.02 S: Manufacturer=HP Inc. S: Product=HP lt4132 LTE/HSPA+ 4G Module S: SerialNumber=0123456789ABCDEF C: #Ifs= 7 Cfg#= 2 Atr=a0 MxPwr=2mA I: If#=0x0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=06 Prot=00 Driver=cdc_ether I: If#=0x1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=06 Prot=00 Driver=cdc_ether I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=06 Prot=10 Driver=option I: If#=0x3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=13 Driver=option I: If#=0x4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=12 Driver=option I: If#=0x5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=14 Driver=option I: If#=0x6 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=1b Driver=option T: Bus=01 Lev=01 Prnt=01 Port=02 Cnt=02 Dev#= 3 Spd=480 MxCh= 0 D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=ff MxPS=64 #Cfgs= 3 P: Vendor=03f0 ProdID=a31d Rev=01.02 S: Manufacturer=HP Inc. S: Product=HP lt4132 LTE/HSPA+ 4G Module S: SerialNumber=0123456789ABCDEF C: #Ifs= 3 Cfg#= 3 Atr=a0 MxPwr=2mA I: If#=0x0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0e Prot=00 Driver=cdc_mbim I: If#=0x1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim I: If#=0x2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=06 Prot=14 Driver=option Signed-off-by: Tore Anderson <tore@fud.no> Cc: stable@vger.kernel.org --- drivers/usb/serial/option.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index e24ff16d4147..1a6fa4726def 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -552,6 +552,10 @@ static void option_instat_callback(struct urb *urb); #define WETELECOM_PRODUCT_6802 0x6802 #define WETELECOM_PRODUCT_WMD300 0x6803 +/* HP products */ +#define HP_VENDOR_ID 0x03f0 +#define HP_PRODUCT_LT4132 0xa31d /* Huawei ME906s-158 */ + /* Device flags */ @@ -1941,6 +1945,11 @@ static const struct usb_device_id option_ids[] = { { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_6802, 0xff, 0xff, 0xff) }, { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_WMD300, 0xff, 0xff, 0xff) }, { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0x421d, 0xff, 0xff, 0xff) }, /* HP lt2523 (Novatel E371) */ + { USB_DEVICE_AND_INTERFACE_INFO(HP_VENDOR_ID, HP_PRODUCT_LT4132, 0xff, 0x06, 0x10) }, + { USB_DEVICE_AND_INTERFACE_INFO(HP_VENDOR_ID, HP_PRODUCT_LT4132, 0xff, 0x06, 0x12) }, + { USB_DEVICE_AND_INTERFACE_INFO(HP_VENDOR_ID, HP_PRODUCT_LT4132, 0xff, 0x06, 0x13) }, + { USB_DEVICE_AND_INTERFACE_INFO(HP_VENDOR_ID, HP_PRODUCT_LT4132, 0xff, 0x06, 0x14) }, + { USB_DEVICE_AND_INTERFACE_INFO(HP_VENDOR_ID, HP_PRODUCT_LT4132, 0xff, 0x06, 0x1b) }, { } /* Terminating entry */ }; MODULE_DEVICE_TABLE(usb, option_ids); -- 2.19.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: serial: option: add HP lt4132 2018-12-08 18:05 [PATCH] USB: serial: option: add HP lt4132 Tore Anderson @ 2018-12-09 15:21 ` Sasha Levin 2018-12-10 8:53 ` Johan Hovold 2018-12-10 9:06 ` Johan Hovold 1 sibling, 1 reply; 6+ messages in thread From: Sasha Levin @ 2018-12-09 15:21 UTC (permalink / raw) To: Sasha Levin, Tore Anderson, Johan Hovold Cc: Tore Anderson, stable, stable, stable Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: all The bot has tested the following trees: v4.19.8, v4.14.87, v4.9.144, v4.4.166, v3.18.128, v4.19.8: Build OK! v4.14.87: Build OK! v4.9.144: Build OK! v4.4.166: Build OK! v3.18.128: Failed to apply! Possible dependencies: 5d03a2fd2292 ("USB: serial: option: add device ID for HP lt2523 (Novatel E371)") How should we proceed with this patch? -- Thanks, Sasha ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: serial: option: add HP lt4132 2018-12-09 15:21 ` Sasha Levin @ 2018-12-10 8:53 ` Johan Hovold 2018-12-11 0:03 ` Sasha Levin 0 siblings, 1 reply; 6+ messages in thread From: Johan Hovold @ 2018-12-10 8:53 UTC (permalink / raw) To: Sasha Levin; +Cc: Tore Anderson, Johan Hovold, stable On Sun, Dec 09, 2018 at 03:21:00PM +0000, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a -stable tag. > The stable tag indicates that it's relevant for the following trees: all > > The bot has tested the following trees: v4.19.8, v4.14.87, v4.9.144, v4.4.166, v3.18.128, > > v4.19.8: Build OK! > v4.14.87: Build OK! > v4.9.144: Build OK! > v4.4.166: Build OK! > v3.18.128: Failed to apply! Possible dependencies: > 5d03a2fd2292 ("USB: serial: option: add device ID for HP lt2523 (Novatel E371)") I thought 3.18 was finally EOLed? > How should we proceed with this patch? It applies just fine to mainline, but looks like your scripts found a missing stable patch which would also make it apply to 3.18 without the need to adjust any context. Thanks, Johan ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: serial: option: add HP lt4132 2018-12-10 8:53 ` Johan Hovold @ 2018-12-11 0:03 ` Sasha Levin 2018-12-11 11:20 ` Johan Hovold 0 siblings, 1 reply; 6+ messages in thread From: Sasha Levin @ 2018-12-11 0:03 UTC (permalink / raw) To: Johan Hovold; +Cc: Tore Anderson, stable On Mon, Dec 10, 2018 at 09:53:17AM +0100, Johan Hovold wrote: >On Sun, Dec 09, 2018 at 03:21:00PM +0000, Sasha Levin wrote: >> Hi, >> >> [This is an automated email] >> >> This commit has been processed because it contains a -stable tag. >> The stable tag indicates that it's relevant for the following trees: all >> >> The bot has tested the following trees: v4.19.8, v4.14.87, v4.9.144, v4.4.166, v3.18.128, >> >> v4.19.8: Build OK! >> v4.14.87: Build OK! >> v4.9.144: Build OK! >> v4.4.166: Build OK! >> v3.18.128: Failed to apply! Possible dependencies: >> 5d03a2fd2292 ("USB: serial: option: add device ID for HP lt2523 (Novatel E371)") > >I thought 3.18 was finally EOLed? Sadly it's still alive. >> How should we proceed with this patch? > >It applies just fine to mainline, but looks like your scripts found a >missing stable patch which would also make it apply to 3.18 without the >need to adjust any context. I'll grab 5d03a2fd2292 too, as it's also adding IDs. -- Thanks, Sasha ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: serial: option: add HP lt4132 2018-12-11 0:03 ` Sasha Levin @ 2018-12-11 11:20 ` Johan Hovold 0 siblings, 0 replies; 6+ messages in thread From: Johan Hovold @ 2018-12-11 11:20 UTC (permalink / raw) To: Sasha Levin; +Cc: Johan Hovold, Tore Anderson, stable On Mon, Dec 10, 2018 at 07:03:25PM -0500, Sasha Levin wrote: > On Mon, Dec 10, 2018 at 09:53:17AM +0100, Johan Hovold wrote: > >On Sun, Dec 09, 2018 at 03:21:00PM +0000, Sasha Levin wrote: > >> Hi, > >> > >> [This is an automated email] > >> > >> This commit has been processed because it contains a -stable tag. > >> The stable tag indicates that it's relevant for the following trees: all > >> > >> The bot has tested the following trees: v4.19.8, v4.14.87, v4.9.144, v4.4.166, v3.18.128, > >> > >> v4.19.8: Build OK! > >> v4.14.87: Build OK! > >> v4.9.144: Build OK! > >> v4.4.166: Build OK! > >> v3.18.128: Failed to apply! Possible dependencies: > >> 5d03a2fd2292 ("USB: serial: option: add device ID for HP lt2523 (Novatel E371)") > > > >I thought 3.18 was finally EOLed? > > Sadly it's still alive. Ah, the note from Greg in the 3.18.125 announcement said he might stop "soon", but I guess the EOL mark on kernel.org has been there since the first time it was declared EOL? > >> How should we proceed with this patch? > > > >It applies just fine to mainline, but looks like your scripts found a > >missing stable patch which would also make it apply to 3.18 without the > >need to adjust any context. > > I'll grab 5d03a2fd2292 too, as it's also adding IDs. Makes sense. Perhaps something that was missed after 3.18-stable's first resurrection. Thanks, Johan ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB: serial: option: add HP lt4132 2018-12-08 18:05 [PATCH] USB: serial: option: add HP lt4132 Tore Anderson 2018-12-09 15:21 ` Sasha Levin @ 2018-12-10 9:06 ` Johan Hovold 1 sibling, 0 replies; 6+ messages in thread From: Johan Hovold @ 2018-12-10 9:06 UTC (permalink / raw) To: Tore Anderson Cc: Johan Hovold, Greg Kroah-Hartman, linux-usb, linux-kernel, stable On Sat, Dec 08, 2018 at 07:05:12PM +0100, Tore Anderson wrote: > The HP lt4132 is a rebranded Huawei ME906s-158 LTE modem. > > The interface with protocol 0x16 is "CDC ECM & NCM" according to the *.inf > files included with the Windows driver. Attaching the option driver to it > doesn't result in a /dev/ttyUSB* device being created, so I've excluded it. > Note that it is also excluded for corresponding Huawei-branded devices, cf. > commit d544db293a44a. > Signed-off-by: Tore Anderson <tore@fud.no> > Cc: stable@vger.kernel.org > --- > drivers/usb/serial/option.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index e24ff16d4147..1a6fa4726def 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -552,6 +552,10 @@ static void option_instat_callback(struct urb *urb); > #define WETELECOM_PRODUCT_6802 0x6802 > #define WETELECOM_PRODUCT_WMD300 0x6803 > > +/* HP products */ > +#define HP_VENDOR_ID 0x03f0 > +#define HP_PRODUCT_LT4132 0xa31d /* Huawei ME906s-158 */ > + > > /* Device flags */ > > @@ -1941,6 +1945,11 @@ static const struct usb_device_id option_ids[] = { > { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_6802, 0xff, 0xff, 0xff) }, > { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_WMD300, 0xff, 0xff, 0xff) }, > { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0x421d, 0xff, 0xff, 0xff) }, /* HP lt2523 (Novatel E371) */ > + { USB_DEVICE_AND_INTERFACE_INFO(HP_VENDOR_ID, HP_PRODUCT_LT4132, 0xff, 0x06, 0x10) }, > + { USB_DEVICE_AND_INTERFACE_INFO(HP_VENDOR_ID, HP_PRODUCT_LT4132, 0xff, 0x06, 0x12) }, > + { USB_DEVICE_AND_INTERFACE_INFO(HP_VENDOR_ID, HP_PRODUCT_LT4132, 0xff, 0x06, 0x13) }, > + { USB_DEVICE_AND_INTERFACE_INFO(HP_VENDOR_ID, HP_PRODUCT_LT4132, 0xff, 0x06, 0x14) }, > + { USB_DEVICE_AND_INTERFACE_INFO(HP_VENDOR_ID, HP_PRODUCT_LT4132, 0xff, 0x06, 0x1b) }, I replaced the defines with numerical constants as we're trying to move away from using the former (and also for consistency with the current HP entry just above): - { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0x421d, 0xff, 0xff, 0xff) }, /* HP lt2523 (Novatel E371) */ + { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0x421d, 0xff, 0xff, 0xff) }, /* HP lt2523 (Novatel E371) */ + { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0xa31d, 0xff, 0x06, 0x10) }, /* HP lt4132 (Huawei ME906s-158) */ + { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0xa31d, 0xff, 0x06, 0x12) }, + { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0xa31d, 0xff, 0x06, 0x13) }, + { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0xa31d, 0xff, 0x06, 0x14) }, + { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0xa31d, 0xff, 0x06, 0x1b) }, Now applied. Thanks, Johan ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-11 11:20 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-12-08 18:05 [PATCH] USB: serial: option: add HP lt4132 Tore Anderson 2018-12-09 15:21 ` Sasha Levin 2018-12-10 8:53 ` Johan Hovold 2018-12-11 0:03 ` Sasha Levin 2018-12-11 11:20 ` Johan Hovold 2018-12-10 9:06 ` Johan Hovold
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).