From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com ([209.85.128.66]:33174 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726240AbeLKKSc (ORCPT ); Tue, 11 Dec 2018 05:18:32 -0500 Received: by mail-wm1-f66.google.com with SMTP id r24so8634258wmh.0 for ; Tue, 11 Dec 2018 02:18:31 -0800 (PST) Date: Tue, 11 Dec 2018 10:18:28 +0000 From: Lee Jones To: Enric Balletbo i Serra Cc: groeck@chromium.org, gwendal@chromium.org, kernel@collabora.com, bleung@chromium.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mfd: cros_ec_dev: Add missing mfd_remove_devices() call in remove Message-ID: <20181211101828.GG4497@dell> References: <20181210180002.4440-1-enric.balletbo@collabora.com> <20181211061207.GE4497@dell> <188dacba-9b4e-3884-d4b3-588b865a1f65@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <188dacba-9b4e-3884-d4b3-588b865a1f65@collabora.com> Sender: stable-owner@vger.kernel.org List-ID: On Tue, 11 Dec 2018, Enric Balletbo i Serra wrote: > Hi Lee, > > On 11/12/18 7:12, Lee Jones wrote: > > On Mon, 10 Dec 2018, Enric Balletbo i Serra wrote: > > > >> The driver adds different MFD child devices via mfd_add_devices() and > >> hence it is required to call mfd_remove_devices() to remove MFD child > >> devices. > >> > >> Fixes: 5e0115581bbc ("cros_ec: Move cros_ec_dev module to drivers/mfd") > >> Cc: stable@vger.kernel.org > >> Signed-off-by: Enric Balletbo i Serra > >> --- > >> Hi Lee, > >> > >> I saw that you send a mfd-fixes pull request this morning, so sorry in > >> advance for sending this too late. This was broken since the driver > >> moved from platform/chrome to mfd (and probably before that), so > >> it's an old problem. Note that I plan to send a patch series that depends > >> on this to apply cleanly. If the patch is fine with you and there is any > >> possibility to go in this version that will be good, if not, let me know > >> if you prefer queue this in your for-next branch or if you prefer I > >> include the patch on the series I plan to send on top of it to not mess > >> things. > > > > It wouldn't have made the v4.20-rcs anyway. Even if you did send it > > earlier. I only send fixes to that -rcs which fix issues introduced > > during the current release cycle. > > > > Ok. > > > If memory serves, doesn't this driver now (or will in the very near > > future) use devm_* for device creation? That would make this patch > > either incorrect (should be devm_mfd_remove_devices() if really > > required) or moot? > > > > I think you have in mind this patch [1], right? Note that in this patch we're > using devm_* for cros_ec driver, _not_ cros_ec_dev driver which is different. Ah yes, that was it. > For the cros_ec_dev driver we need to take care with device managed allocations > as explained in the last fix merged [2]. For the cros_ec_dev I was trying to no > mix device managed allocations with non-device managed allocations, and as we > can't use devm_kzalloc in this case, I thought that was worth use the > mfd_add/mfd_remove functions like is now. Makes sense? What are your thoughts here? The patch is fine then. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog