From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f68.google.com ([209.85.128.68]:56213 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726446AbeLKKSp (ORCPT ); Tue, 11 Dec 2018 05:18:45 -0500 Received: by mail-wm1-f68.google.com with SMTP id y139so1563587wmc.5 for ; Tue, 11 Dec 2018 02:18:44 -0800 (PST) Date: Tue, 11 Dec 2018 10:18:41 +0000 From: Lee Jones To: Enric Balletbo i Serra Cc: groeck@chromium.org, gwendal@chromium.org, kernel@collabora.com, bleung@chromium.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mfd: cros_ec_dev: Add missing mfd_remove_devices() call in remove Message-ID: <20181211101841.GH4497@dell> References: <20181210180002.4440-1-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20181210180002.4440-1-enric.balletbo@collabora.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, 10 Dec 2018, Enric Balletbo i Serra wrote: > The driver adds different MFD child devices via mfd_add_devices() and > hence it is required to call mfd_remove_devices() to remove MFD child > devices. > > Fixes: 5e0115581bbc ("cros_ec: Move cros_ec_dev module to drivers/mfd") > Cc: stable@vger.kernel.org > Signed-off-by: Enric Balletbo i Serra > --- > Hi Lee, > > I saw that you send a mfd-fixes pull request this morning, so sorry in > advance for sending this too late. This was broken since the driver > moved from platform/chrome to mfd (and probably before that), so > it's an old problem. Note that I plan to send a patch series that depends > on this to apply cleanly. If the patch is fine with you and there is any > possibility to go in this version that will be good, if not, let me know > if you prefer queue this in your for-next branch or if you prefer I > include the patch on the series I plan to send on top of it to not mess > things. > > Thanks, > Enric > > drivers/mfd/cros_ec_dev.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog