From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from vie01a-dmta-pe06-1.mx.upcmail.net ([84.116.36.14]:42452 "EHLO
        vie01a-dmta-pe06-1.mx.upcmail.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1726416AbeLMCVV (ORCPT
        <rfc822;stable@vger.kernel.org>); Wed, 12 Dec 2018 21:21:21 -0500
Received: from [172.31.216.234] (helo=vie01a-pemc-psmtp-pe11.mail.upcmail.net)
        by vie01a-dmta-pe06.mx.upcmail.net with esmtp (Exim 4.88)
        (envelope-from <thomas.zeitlhofer@ze-it.at>)
        id 1gXGco-0002Gp-Nl
        for stable@vger.kernel.org; Thu, 13 Dec 2018 03:21:18 +0100
Date: Thu, 13 Dec 2018 03:21:07 +0100
From: Thomas Zeitlhofer <thomas.zeitlhofer@ze-it.at>
To: Hui Wang <hui.wang@canonical.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Kailang Yang <kailang@realtek.com>,
        Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 4.19 096/139] ALSA: hda/realtek - fix the pop noise on
 headphone for lenovo laptops
Message-ID: <20181213022107.GA4450@x1>
References: <20181204103649.950154335@linuxfoundation.org>
 <20181204103654.341269777@linuxfoundation.org>
 <20181212234517.GA15065@x1>
 <1fe3ba5d-d77a-4592-c5c9-67d788d8b434@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1fe3ba5d-d77a-4592-c5c9-67d788d8b434@canonical.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

Hello Hui,

On Thu, Dec 13, 2018 at 08:23:40AM +0800, Hui Wang wrote:
> Hello Thomas,
> 
> I have sent a new patch to fix this LED regression, after applying
> this patch (ALSA: hda/realtek - fix the pop noise on headphone for
> lenovo laptops) and the new patch (ALSA: hda/realtek - Fix the mute
> LED regresion on Lenovo X1 �Carbon),� the issue will be fixed.
> 
> This is the new patch I sent (also CCed to stable):
> 
> http://mailman.alsa-project.org/pipermail/alsa-devel/2018-December/142747.html

thanks, I can confirm that this fixes the LED regression.

> About the noise, if you follow the steps as below, you would hear the
> noticeable click/pop noise:
> 
> 1. Hookup a set of headphones that you can separately place in/on your
> ears.  (ie. ear buds)
> 
> 2. Put only the right headphone in/on your ear.
> 
> 3. Go to the Gnome sound settings and bring up the "Test Speakers"
> function
> 
> 4. Play the left speaker test
> 
> You would expect to hear nothing in the right ear, but instead you
> hear a "pop" at the start of each word spoken. ("pop" Front "pop"
> left). You can repeat with the left headphone and see similar results.
> I even tried shifting the balance all the way to the left/right and
> get the same results.

Thank you for elaborating on the noise problem - now I could also
reproduce it and see that your patch (ALSA: hda/realtek - fix the pop
noise on headphone for lenovo laptops) fixes it.

Regards,

Thomas