From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f67.google.com ([209.85.167.67]:45174 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729281AbeLMNe4 (ORCPT ); Thu, 13 Dec 2018 08:34:56 -0500 Date: Thu, 13 Dec 2018 14:34:59 +0100 From: Johan Hovold To: Andreas Kemnade Cc: Johan Hovold , stable , linux-kernel@vger.kernel.org Subject: Re: [PATCH] gnss: sirf: fix activation retry handling Message-ID: <20181213133459.GO3500@localhost> References: <20181205102149.21167-1-johan@kernel.org> <20181209205802.081b64f2@aktux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181209205802.081b64f2@aktux> Sender: stable-owner@vger.kernel.org List-ID: On Sun, Dec 09, 2018 at 08:58:02PM +0100, Andreas Kemnade wrote: > Hi, > > On Wed, 5 Dec 2018 11:21:49 +0100 > Johan Hovold wrote: > > > Fix activation helper which would return -ETIMEDOUT even if the last > > retry attempt was successful. > > > > Also change the semantics of the retries variable so that it actually > > holds the number of retries (rather than tries). > Sounds sane. I rebased my patch series on top of it and improved my > testing script (the manual on/off toggle in between was not working > properly) That's great. And thanks for testing. I'm a bit short on time at the moment, but will try to take at least a quick look at your v2 today. Johan