From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
Miquel Raynal <miquel.raynal@bootlin.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: omap2: Pass the parent of pdev to dma_request_chan()
Date: Thu, 13 Dec 2018 20:51:16 +0100 [thread overview]
Message-ID: <20181213205116.a1ca55bbd45ad1157563b33e@gmail.com> (raw)
In-Reply-To: <20181213192227.3815-1-boris.brezillon@bootlin.com>
Hello Boris!
On Thu, 13 Dec 2018 20:22:27 +0100
Boris Brezillon <boris.brezillon@bootlin.com> wrote:
> Commit e1e6255c311b ("mtd: rawnand: omap2: convert driver to
> nand_scan()") moved part of the init code in the ->attach_chip hook
> and at the same time changed the struct device object passed to
> dma_request_chan() (&pdev->dev instead of pdev->dev.parent).
>
> Fixes: e1e6255c311b ("mtd: rawnand: omap2: convert driver to nand_scan()")
> Reported-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Yes, it was it, thank you!
Tested-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> Changes in v2:
> - Fix the prefix
> ---
> drivers/mtd/nand/raw/omap2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/omap2.c b/drivers/mtd/nand/raw/omap2.c
> index 886d05c391ef..68e8b9f7f372 100644
> --- a/drivers/mtd/nand/raw/omap2.c
> +++ b/drivers/mtd/nand/raw/omap2.c
> @@ -1944,7 +1944,7 @@ static int omap_nand_attach_chip(struct nand_chip *chip)
> case NAND_OMAP_PREFETCH_DMA:
> dma_cap_zero(mask);
> dma_cap_set(DMA_SLAVE, mask);
> - info->dma = dma_request_chan(dev, "rxtx");
> + info->dma = dma_request_chan(dev->parent, "rxtx");
>
> if (IS_ERR(info->dma)) {
> dev_err(dev, "DMA engine request failed\n");
> --
> 2.17.1
>
--
Alexander Sverdlin.
next prev parent reply other threads:[~2018-12-13 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 19:22 [PATCH v2] mtd: rawnand: omap2: Pass the parent of pdev to dma_request_chan() Boris Brezillon
2018-12-13 19:51 ` Alexander Sverdlin [this message]
2018-12-15 10:27 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213205116.a1ca55bbd45ad1157563b33e@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).