* [PATCH v2] mtd: rawnand: omap2: Pass the parent of pdev to dma_request_chan()
@ 2018-12-13 19:22 Boris Brezillon
2018-12-13 19:51 ` Alexander Sverdlin
2018-12-15 10:27 ` Miquel Raynal
0 siblings, 2 replies; 3+ messages in thread
From: Boris Brezillon @ 2018-12-13 19:22 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, Miquel Raynal, linux-mtd
Cc: Alexander Sverdlin, David Woodhouse, Brian Norris, Marek Vasut,
stable
Commit e1e6255c311b ("mtd: rawnand: omap2: convert driver to
nand_scan()") moved part of the init code in the ->attach_chip hook
and at the same time changed the struct device object passed to
dma_request_chan() (&pdev->dev instead of pdev->dev.parent).
Fixes: e1e6255c311b ("mtd: rawnand: omap2: convert driver to nand_scan()")
Reported-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
---
Changes in v2:
- Fix the prefix
---
drivers/mtd/nand/raw/omap2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/omap2.c b/drivers/mtd/nand/raw/omap2.c
index 886d05c391ef..68e8b9f7f372 100644
--- a/drivers/mtd/nand/raw/omap2.c
+++ b/drivers/mtd/nand/raw/omap2.c
@@ -1944,7 +1944,7 @@ static int omap_nand_attach_chip(struct nand_chip *chip)
case NAND_OMAP_PREFETCH_DMA:
dma_cap_zero(mask);
dma_cap_set(DMA_SLAVE, mask);
- info->dma = dma_request_chan(dev, "rxtx");
+ info->dma = dma_request_chan(dev->parent, "rxtx");
if (IS_ERR(info->dma)) {
dev_err(dev, "DMA engine request failed\n");
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] mtd: rawnand: omap2: Pass the parent of pdev to dma_request_chan()
2018-12-13 19:22 [PATCH v2] mtd: rawnand: omap2: Pass the parent of pdev to dma_request_chan() Boris Brezillon
@ 2018-12-13 19:51 ` Alexander Sverdlin
2018-12-15 10:27 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Sverdlin @ 2018-12-13 19:51 UTC (permalink / raw)
To: Boris Brezillon
Cc: Richard Weinberger, Miquel Raynal, linux-mtd, David Woodhouse,
Brian Norris, Marek Vasut, stable
Hello Boris!
On Thu, 13 Dec 2018 20:22:27 +0100
Boris Brezillon <boris.brezillon@bootlin.com> wrote:
> Commit e1e6255c311b ("mtd: rawnand: omap2: convert driver to
> nand_scan()") moved part of the init code in the ->attach_chip hook
> and at the same time changed the struct device object passed to
> dma_request_chan() (&pdev->dev instead of pdev->dev.parent).
>
> Fixes: e1e6255c311b ("mtd: rawnand: omap2: convert driver to nand_scan()")
> Reported-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Yes, it was it, thank you!
Tested-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> Changes in v2:
> - Fix the prefix
> ---
> drivers/mtd/nand/raw/omap2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/omap2.c b/drivers/mtd/nand/raw/omap2.c
> index 886d05c391ef..68e8b9f7f372 100644
> --- a/drivers/mtd/nand/raw/omap2.c
> +++ b/drivers/mtd/nand/raw/omap2.c
> @@ -1944,7 +1944,7 @@ static int omap_nand_attach_chip(struct nand_chip *chip)
> case NAND_OMAP_PREFETCH_DMA:
> dma_cap_zero(mask);
> dma_cap_set(DMA_SLAVE, mask);
> - info->dma = dma_request_chan(dev, "rxtx");
> + info->dma = dma_request_chan(dev->parent, "rxtx");
>
> if (IS_ERR(info->dma)) {
> dev_err(dev, "DMA engine request failed\n");
> --
> 2.17.1
>
--
Alexander Sverdlin.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] mtd: rawnand: omap2: Pass the parent of pdev to dma_request_chan()
2018-12-13 19:22 [PATCH v2] mtd: rawnand: omap2: Pass the parent of pdev to dma_request_chan() Boris Brezillon
2018-12-13 19:51 ` Alexander Sverdlin
@ 2018-12-15 10:27 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2018-12-15 10:27 UTC (permalink / raw)
To: Boris Brezillon
Cc: Richard Weinberger, linux-mtd, Alexander Sverdlin,
David Woodhouse, Brian Norris, Marek Vasut, stable
Hi Boris,
Boris Brezillon <boris.brezillon@bootlin.com> wrote on Thu, 13 Dec 2018
20:22:27 +0100:
> Commit e1e6255c311b ("mtd: rawnand: omap2: convert driver to
> nand_scan()") moved part of the init code in the ->attach_chip hook
> and at the same time changed the struct device object passed to
> dma_request_chan() (&pdev->dev instead of pdev->dev.parent).
>
> Fixes: e1e6255c311b ("mtd: rawnand: omap2: convert driver to nand_scan()")
> Reported-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
Applied on nand/next,
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-15 10:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-13 19:22 [PATCH v2] mtd: rawnand: omap2: Pass the parent of pdev to dma_request_chan() Boris Brezillon
2018-12-13 19:51 ` Alexander Sverdlin
2018-12-15 10:27 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).