* Patches for v4.4.y, v4.9.y, and v4.14.y to address rbtree test failures
@ 2018-12-14 5:22 Guenter Roeck
2018-12-14 7:03 ` Greg Kroah-Hartman
2018-12-14 8:06 ` Greg Kroah-Hartman
0 siblings, 2 replies; 6+ messages in thread
From: Guenter Roeck @ 2018-12-14 5:22 UTC (permalink / raw)
To: stable; +Cc: Greg Kroah-Hartman, Sasha Levin
Hi folks,
I recently started seeing spurious test failures with rbtree tests,
resulting in boot delays and random "hung task" warnings.
The problems have been fixed upstream with the following patches.
v4.14.y:
0b548e33e6cb lib/rbtree-test: lower default params
v4.4.y, v4.9.y:
a54dae0338b7 lib/interval_tree_test.c: make test options module parameters
c46ecce431eb lib/interval_tree_test.c: allow full tree search
223f8911eace lib/rbtree_test.c: make input module parameters
0b548e33e6cb lib/rbtree-test: lower default params
The first three patches for v4.4.y and v4.9.y are the minimum
set of context patches needed to avoid conflicts when applying
commit 0b548e33e6cb.
I tested all kernel versions with the patches applied and rbtree
testing enabled to ensure that no new problems are introduced.
Please consider applying those patches to the respective releases.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patches for v4.4.y, v4.9.y, and v4.14.y to address rbtree test failures
2018-12-14 5:22 Patches for v4.4.y, v4.9.y, and v4.14.y to address rbtree test failures Guenter Roeck
@ 2018-12-14 7:03 ` Greg Kroah-Hartman
2018-12-14 8:06 ` Greg Kroah-Hartman
1 sibling, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2018-12-14 7:03 UTC (permalink / raw)
To: Guenter Roeck; +Cc: stable, Sasha Levin
On Thu, Dec 13, 2018 at 09:22:07PM -0800, Guenter Roeck wrote:
> Hi folks,
>
> I recently started seeing spurious test failures with rbtree tests,
> resulting in boot delays and random "hung task" warnings.
> The problems have been fixed upstream with the following patches.
>
> v4.14.y:
>
> 0b548e33e6cb lib/rbtree-test: lower default params
>
> v4.4.y, v4.9.y:
>
> a54dae0338b7 lib/interval_tree_test.c: make test options module parameters
> c46ecce431eb lib/interval_tree_test.c: allow full tree search
> 223f8911eace lib/rbtree_test.c: make input module parameters
> 0b548e33e6cb lib/rbtree-test: lower default params
>
> The first three patches for v4.4.y and v4.9.y are the minimum
> set of context patches needed to avoid conflicts when applying
> commit 0b548e33e6cb.
>
> I tested all kernel versions with the patches applied and rbtree
> testing enabled to ensure that no new problems are introduced.
>
> Please consider applying those patches to the respective releases.
All now queued up, thanks!
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patches for v4.4.y, v4.9.y, and v4.14.y to address rbtree test failures
2018-12-14 5:22 Patches for v4.4.y, v4.9.y, and v4.14.y to address rbtree test failures Guenter Roeck
2018-12-14 7:03 ` Greg Kroah-Hartman
@ 2018-12-14 8:06 ` Greg Kroah-Hartman
2018-12-14 14:19 ` Guenter Roeck
1 sibling, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2018-12-14 8:06 UTC (permalink / raw)
To: Guenter Roeck; +Cc: stable, Sasha Levin
On Thu, Dec 13, 2018 at 09:22:07PM -0800, Guenter Roeck wrote:
> Hi folks,
>
> I recently started seeing spurious test failures with rbtree tests,
> resulting in boot delays and random "hung task" warnings.
> The problems have been fixed upstream with the following patches.
>
> v4.14.y:
>
> 0b548e33e6cb lib/rbtree-test: lower default params
>
> v4.4.y, v4.9.y:
>
> a54dae0338b7 lib/interval_tree_test.c: make test options module parameters
> c46ecce431eb lib/interval_tree_test.c: allow full tree search
Wait, this patch breaks the build for 4.4.y and 4.9.y, so this isn't
going to work well:
lib/interval_tree_test.c: In function ‘interval_tree_test_init’:
lib/interval_tree_test.c:105:38: error: ‘max_endpoint’ undeclared (first use in this function); did you mean ‘tracepoint’?
unsigned long last = search_all ? max_endpoint : queries[j];
^~~~~~~~~~~~
tracepoint
So I'm going to drop these from the 4.4 and 4.9 and 3.18 trees. How did they
build for you?
confused,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Patches for v4.4.y, v4.9.y, and v4.14.y to address rbtree test failures
2018-12-14 8:06 ` Greg Kroah-Hartman
@ 2018-12-14 14:19 ` Guenter Roeck
2018-12-17 22:56 ` Sasha Levin
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2018-12-14 14:19 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: stable, Sasha Levin
On 12/14/18 12:06 AM, Greg Kroah-Hartman wrote:
> On Thu, Dec 13, 2018 at 09:22:07PM -0800, Guenter Roeck wrote:
>> Hi folks,
>>
>> I recently started seeing spurious test failures with rbtree tests,
>> resulting in boot delays and random "hung task" warnings.
>> The problems have been fixed upstream with the following patches.
>>
>> v4.14.y:
>>
>> 0b548e33e6cb lib/rbtree-test: lower default params
>>
>> v4.4.y, v4.9.y:
>>
>> a54dae0338b7 lib/interval_tree_test.c: make test options module parameters
>> c46ecce431eb lib/interval_tree_test.c: allow full tree search
>
> Wait, this patch breaks the build for 4.4.y and 4.9.y, so this isn't
> going to work well:
>
> lib/interval_tree_test.c: In function ‘interval_tree_test_init’:
> lib/interval_tree_test.c:105:38: error: ‘max_endpoint’ undeclared (first use in this function); did you mean ‘tracepoint’?
> unsigned long last = search_all ? max_endpoint : queries[j];
> ^~~~~~~~~~~~
> tracepoint
>
>
> So I'm going to drop these from the 4.4 and 4.9 and 3.18 trees. How did they
> build for you?
>
I had also applied commit a8ec14d4f6aa8e ("lib/interval_tree_test.c: allow users
to limit scope of endpoint") and for some reason dropped that from my e-mail.
Sorry :-(.
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Patches for v4.4.y, v4.9.y, and v4.14.y to address rbtree test failures
2018-12-14 14:19 ` Guenter Roeck
@ 2018-12-17 22:56 ` Sasha Levin
2018-12-18 1:38 ` Guenter Roeck
0 siblings, 1 reply; 6+ messages in thread
From: Sasha Levin @ 2018-12-17 22:56 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Greg Kroah-Hartman, stable
On Fri, Dec 14, 2018 at 06:19:08AM -0800, Guenter Roeck wrote:
>On 12/14/18 12:06 AM, Greg Kroah-Hartman wrote:
>>On Thu, Dec 13, 2018 at 09:22:07PM -0800, Guenter Roeck wrote:
>>>Hi folks,
>>>
>>>I recently started seeing spurious test failures with rbtree tests,
>>>resulting in boot delays and random "hung task" warnings.
>>>The problems have been fixed upstream with the following patches.
>>>
>>>v4.14.y:
>>>
>>>0b548e33e6cb lib/rbtree-test: lower default params
>>>
>>>v4.4.y, v4.9.y:
>>>
>>>a54dae0338b7 lib/interval_tree_test.c: make test options module parameters
>>>c46ecce431eb lib/interval_tree_test.c: allow full tree search
>>
>>Wait, this patch breaks the build for 4.4.y and 4.9.y, so this isn't
>>going to work well:
>>
>>lib/interval_tree_test.c: In function ‘interval_tree_test_init’:
>>lib/interval_tree_test.c:105:38: error: ‘max_endpoint’ undeclared (first use in this function); did you mean ‘tracepoint’?
>> unsigned long last = search_all ? max_endpoint : queries[j];
>> ^~~~~~~~~~~~
>> tracepoint
>>
>>
>>So I'm going to drop these from the 4.4 and 4.9 and 3.18 trees. How did they
>>build for you?
>>
>
>I had also applied commit a8ec14d4f6aa8e ("lib/interval_tree_test.c: allow users
>to limit scope of endpoint") and for some reason dropped that from my e-mail.
I've grabbed a8ec14d4f6aa8e and all other patches for 4.9, 4.4 and 3.18
(and made sure they build fine). Thank you.
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Patches for v4.4.y, v4.9.y, and v4.14.y to address rbtree test failures
2018-12-17 22:56 ` Sasha Levin
@ 2018-12-18 1:38 ` Guenter Roeck
0 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2018-12-18 1:38 UTC (permalink / raw)
To: Sasha Levin; +Cc: Greg Kroah-Hartman, stable
On 12/17/18 2:56 PM, Sasha Levin wrote:
> On Fri, Dec 14, 2018 at 06:19:08AM -0800, Guenter Roeck wrote:
>> On 12/14/18 12:06 AM, Greg Kroah-Hartman wrote:
>>> On Thu, Dec 13, 2018 at 09:22:07PM -0800, Guenter Roeck wrote:
>>>> Hi folks,
>>>>
>>>> I recently started seeing spurious test failures with rbtree tests,
>>>> resulting in boot delays and random "hung task" warnings.
>>>> The problems have been fixed upstream with the following patches.
>>>>
>>>> v4.14.y:
>>>>
>>>> 0b548e33e6cb lib/rbtree-test: lower default params
>>>>
>>>> v4.4.y, v4.9.y:
>>>>
>>>> a54dae0338b7 lib/interval_tree_test.c: make test options module parameters
>>>> c46ecce431eb lib/interval_tree_test.c: allow full tree search
>>>
>>> Wait, this patch breaks the build for 4.4.y and 4.9.y, so this isn't
>>> going to work well:
>>>
>>> lib/interval_tree_test.c: In function ‘interval_tree_test_init’:
>>> lib/interval_tree_test.c:105:38: error: ‘max_endpoint’ undeclared (first use in this function); did you mean ‘tracepoint’?
>>> unsigned long last = search_all ? max_endpoint : queries[j];
>>> ^~~~~~~~~~~~
>>> tracepoint
>>>
>>>
>>> So I'm going to drop these from the 4.4 and 4.9 and 3.18 trees. How did they
>>> build for you?
>>>
>>
>> I had also applied commit a8ec14d4f6aa8e ("lib/interval_tree_test.c: allow users
>> to limit scope of endpoint") and for some reason dropped that from my e-mail.
>
> I've grabbed a8ec14d4f6aa8e and all other patches for 4.9, 4.4 and 3.18
> (and made sure they build fine). Thank you.
>
Thanks, appreciate it, and again sorry for the mess-up.
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-18 1:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-14 5:22 Patches for v4.4.y, v4.9.y, and v4.14.y to address rbtree test failures Guenter Roeck
2018-12-14 7:03 ` Greg Kroah-Hartman
2018-12-14 8:06 ` Greg Kroah-Hartman
2018-12-14 14:19 ` Guenter Roeck
2018-12-17 22:56 ` Sasha Levin
2018-12-18 1:38 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).