From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nwk-aaemail-lapp03.apple.com ([17.151.62.68]:34040 "EHLO nwk-aaemail-lapp03.apple.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730123AbeLNTLy (ORCPT ); Fri, 14 Dec 2018 14:11:54 -0500 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-disposition: inline Content-type: text/plain; CHARSET=US-ASCII Date: Fri, 14 Dec 2018 11:11:44 -0800 From: Christoph Paasch To: David Miller Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, bhole_prashant_q7@lab.ntt.co.jp, tyhicks@canonical.com, eric.dumazet@gmail.com, edumazet@google.com Subject: Re: [PATCH 4.14 09/89] net: Prevent invalid access to skb->prev in __qdisc_drop_all Message-id: <20181214191144.GP41383@MacBook-Pro-19.local> References: <20181214115729.658859279@linuxfoundation.org> <20181214115730.135586551@linuxfoundation.org> <20181214155226.GJ41383@MacBook-Pro-19.local> <20181214.110530.1362956449531434869.davem@davemloft.net> In-reply-to: <20181214.110530.1362956449531434869.davem@davemloft.net> Sender: stable-owner@vger.kernel.org List-ID: On 14/12/18 - 11:05:30, David Miller wrote: > From: Christoph Paasch > Date: Fri, 14 Dec 2018 07:52:26 -0800 > > > I don't think this patch needs to be backported. I haven't hit this panic on > > v4.14.x (although, I only have been using v4.14.79 for now - not yet the > > latest one). And the commits that seem to have introduced the issue haven't > > been backported either AFAICS. That being said, I don't think a backport > > would cause any side-effects. > > > > Or have you seen reports of this panic in the stable branches? > > > > (same for the other stable branches v4.4,... - cfr., the other mails > > regarding this patch here) > > I was being ultra paranoid when I decided to submit this to 4.14 too, > and as Eric says it does not harm. Sounds good to me. I just wanted to point out that I didn't reproduce the issue nor tested the patch on the older stable branches. Christoph