* Re: [PATCH] acpi / apei: fix NULL deref during init [not found] ` <5ec69dad-7943-343b-5ced-9a962652e14c@schoebel-theuer.de> @ 2018-12-14 22:54 ` Borislav Petkov 2018-12-15 8:05 ` Greg KH 0 siblings, 1 reply; 2+ messages in thread From: Borislav Petkov @ 2018-12-14 22:54 UTC (permalink / raw) To: Thomas Schöbel-Theuer Cc: Thomas Schoebel-Theuer, linux-kernel, Laura Abbott, Rafael J. Wysocki, Len Brown, Tony Luck, linux-acpi, stable On Fri, Dec 14, 2018 at 11:42:01PM +0100, Thomas Schöbel-Theuer wrote: > Ah, I overlooked that commit e56c92565dfe2 is already providing a different > solution to the same problem in newer kernels _only_, as a _side_ effect > (not clear to me from the description, but clear from reading the code). Damn, I missed the fact that this is not the upstream kernel: CPU: 0 PID: 1 UID: 0 Comm: swapper/0 Not tainted 4.4.0-ui18344.004-uiabi1-infong-amd64 #1 > So another alternative would be backporting e56c92565dfe2 to the 4.4 LTS > series. Also fine for me. That looks like the right fix. A note for the next time: do not send a fix for a stable kernel which is not upstream: >From Documentation/process/stable-kernel-rules.rst: " - It or an equivalent fix must already exist in Linus' tree (upstream)." The stable kernels track upstream so if a stable kernel has a problem, the first thing one needs to do is to check whether this has been fixed upstream and if so, to backport it. This is the case most of the time. In the very seldom cases where a separate fix is needed, it needs to be handled by asking Greg what to do. :-) Adding stable@ folks to CC to set me straight if I'm missing something. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] acpi / apei: fix NULL deref during init 2018-12-14 22:54 ` [PATCH] acpi / apei: fix NULL deref during init Borislav Petkov @ 2018-12-15 8:05 ` Greg KH 0 siblings, 0 replies; 2+ messages in thread From: Greg KH @ 2018-12-15 8:05 UTC (permalink / raw) To: Borislav Petkov Cc: Thomas Schöbel-Theuer, Thomas Schoebel-Theuer, linux-kernel, Laura Abbott, Rafael J. Wysocki, Len Brown, Tony Luck, linux-acpi, stable On Fri, Dec 14, 2018 at 11:54:28PM +0100, Borislav Petkov wrote: > On Fri, Dec 14, 2018 at 11:42:01PM +0100, Thomas Sch�bel-Theuer wrote: > > Ah, I overlooked that commit e56c92565dfe2 is already providing a different > > solution to the same problem in newer kernels _only_, as a _side_ effect > > (not clear to me from the description, but clear from reading the code). > > Damn, I missed the fact that this is not the upstream kernel: > > CPU: 0 PID: 1 UID: 0 Comm: swapper/0 Not tainted 4.4.0-ui18344.004-uiabi1-infong-amd64 #1 > > > So another alternative would be backporting e56c92565dfe2 to the 4.4 LTS > > series. Also fine for me. > > That looks like the right fix. > > A note for the next time: do not send a fix for a stable kernel which is > not upstream: > > >From Documentation/process/stable-kernel-rules.rst: > > " - It or an equivalent fix must already exist in Linus' tree (upstream)." > > The stable kernels track upstream so if a stable kernel has a problem, > the first thing one needs to do is to check whether this has been fixed > upstream and if so, to backport it. This is the case most of the time. > In the very seldom cases where a separate fix is needed, it needs to be > handled by asking Greg what to do. :-) > > Adding stable@ folks to CC to set me straight if I'm missing something. Nope, you are correct, thanks! greg k-h ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-15 8:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20181214181514.29891-1-tst@schoebel-theuer.de>
[not found] ` <20181214202406.GI11710@zn.tnic>
[not found] ` <c8d62037-4a26-e18b-51a3-73fc99e76e5b@schoebel-theuer.de>
[not found] ` <5ec69dad-7943-343b-5ced-9a962652e14c@schoebel-theuer.de>
2018-12-14 22:54 ` [PATCH] acpi / apei: fix NULL deref during init Borislav Petkov
2018-12-15 8:05 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).