stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Loic <hackurx@opensec.fr>
Cc: debian-kernel@lists.debian.org, carnil@debian.org,
	ben@decadent.org.uk, Steven Rostedt <rostedt@goodmis.org>,
	stable@vger.kernel.org, ameyt@codeaurora.org,
	amit.pundir@linaro.org
Subject: Re: [PATCH] tracing: Use strlcpy() instead of strcpy() in __trace_find_cmdline()
Date: Mon, 17 Dec 2018 22:05:58 +0100	[thread overview]
Message-ID: <20181217210558.GB2758@kroah.com> (raw)
In-Reply-To: <6af2b12206e8a640a0a30f78d4414b56@opensec.fr>

On Mon, Dec 17, 2018 at 08:42:38PM +0100, Loic wrote:
> Le 2018-12-17 09:19, Greg KH a �crit�:
> > On Sun, Dec 16, 2018 at 09:08:20PM +0100, Loic wrote:
> > > Le 2018-12-16 20:27, Steven Rostedt a �crit�:
> > > > On Sun, 16 Dec 2018 09:52:33 +0100
> > > > Greg KH <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > > On Sat, Dec 15, 2018 at 06:25:37PM +0100, Loic wrote:
> > > > > > Hello,
> > > > > >
> > > > > > Please picked up this patch for linux 4.4 and 4.9.
> > > > > > This fixes CVE-2017-0605 (Rejected?). Tested in Debian ;)
> > > > >
> > > > > It was rejected as a CVE for a good reason, and that reason is also
> > > > > why
> > > > > I refused to add it to the stable kernel releases.  In short, this is
> > > > > not an issue or bug at all, there is nothing wrong with the existing
> > > > > code.
> > > > >
> > > >
> > > > I'm starting to regret that I ever accepted the original patch :-(
> > > >
> > > > -- Steve
> > > 
> > > Okay, I hadn't looked at the previous conversations because this
> > > change is
> > > in the upstream and in debian...
> > 
> > Upstream is fine, it's a valid change so that people don't keep sending
> > the crazy patch over and over.
> > 
> > Debian is just cargo-culting the thing and should probably drop it as it
> > keeps coming back to me every 3 months or so, and I have to reject it
> > again :(
> > 
> > thanks,
> > 
> > greg k-h
> 
> Why didn't you follow the upstream or add a comment "no change for fake
> CVE-2017-0605" to break the debian patch ?

How can I change upstream?  The commit can not be changed once it is
merged.

greg k-h

  parent reply	other threads:[~2018-12-17 21:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-15 17:25 [PATCH] tracing: Use strlcpy() instead of strcpy() in __trace_find_cmdline() Loic
2018-12-15 20:12 ` Salvatore Bonaccorso
2018-12-16  8:52 ` Greg KH
2018-12-16 19:27   ` Steven Rostedt
2018-12-16 20:08     ` Loic
2018-12-17  8:19       ` Greg KH
2018-12-17 19:42         ` Loic
2018-12-17 20:57           ` Sasha Levin
2018-12-17 21:05           ` Greg KH [this message]
2018-12-18 17:45             ` Loic
2018-12-18  3:00           ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217210558.GB2758@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ameyt@codeaurora.org \
    --cc=amit.pundir@linaro.org \
    --cc=ben@decadent.org.uk \
    --cc=carnil@debian.org \
    --cc=debian-kernel@lists.debian.org \
    --cc=hackurx@opensec.fr \
    --cc=rostedt@goodmis.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).