From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:41340 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728393AbeLQW4W (ORCPT ); Mon, 17 Dec 2018 17:56:22 -0500 Date: Mon, 17 Dec 2018 17:56:20 -0500 From: Sasha Levin To: Guenter Roeck Cc: Greg Kroah-Hartman , stable Subject: Re: Patches for v4.4.y, v4.9.y, and v4.14.y to address rbtree test failures Message-ID: <20181217225620.GU2746@sasha-vm> References: <1e712ab5-74f6-077e-af82-117f4b856f22@roeck-us.net> <20181214080643.GA12329@kroah.com> <50a153e2-4310-607b-5c36-64cffcebca6b@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <50a153e2-4310-607b-5c36-64cffcebca6b@roeck-us.net> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Dec 14, 2018 at 06:19:08AM -0800, Guenter Roeck wrote: >On 12/14/18 12:06 AM, Greg Kroah-Hartman wrote: >>On Thu, Dec 13, 2018 at 09:22:07PM -0800, Guenter Roeck wrote: >>>Hi folks, >>> >>>I recently started seeing spurious test failures with rbtree tests, >>>resulting in boot delays and random "hung task" warnings. >>>The problems have been fixed upstream with the following patches. >>> >>>v4.14.y: >>> >>>0b548e33e6cb lib/rbtree-test: lower default params >>> >>>v4.4.y, v4.9.y: >>> >>>a54dae0338b7 lib/interval_tree_test.c: make test options module parameters >>>c46ecce431eb lib/interval_tree_test.c: allow full tree search >> >>Wait, this patch breaks the build for 4.4.y and 4.9.y, so this isn't >>going to work well: >> >>lib/interval_tree_test.c: In function ‘interval_tree_test_init’: >>lib/interval_tree_test.c:105:38: error: ‘max_endpoint’ undeclared (first use in this function); did you mean ‘tracepoint’? >> unsigned long last = search_all ? max_endpoint : queries[j]; >> ^~~~~~~~~~~~ >> tracepoint >> >> >>So I'm going to drop these from the 4.4 and 4.9 and 3.18 trees. How did they >>build for you? >> > >I had also applied commit a8ec14d4f6aa8e ("lib/interval_tree_test.c: allow users >to limit scope of endpoint") and for some reason dropped that from my e-mail. I've grabbed a8ec14d4f6aa8e and all other patches for 4.9, 4.4 and 3.18 (and made sure they build fine). Thank you. -- Thanks, Sasha