From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 18 Dec 2018 14:10:53 -0800 From: Andrew Morton To: Mike Kravetz Cc: "Aneesh Kumar K.V" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Hugh Dickins , Naoya Horiguchi , "Aneesh Kumar K . V" , Andrea Arcangeli , "Kirill A . Shutemov" , Davidlohr Bueso , Prakash Sangappa , stable@vger.kernel.org Subject: Re: [PATCH 2/3] hugetlbfs: Use i_mmap_rwsem to fix page fault/truncate race Message-Id: <20181218141053.e2725111ce5cc91493efab5f@linux-foundation.org> In-Reply-To: References: <20181203200850.6460-1-mike.kravetz@oracle.com> <20181203200850.6460-3-mike.kravetz@oracle.com> <27f8893b-57b3-088d-2d48-9e8acc5987bd@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: On Mon, 17 Dec 2018 16:17:52 -0800 Mike Kravetz wrote: > ... > > > As you suggested in a comment to the subsequent patch, it would be better to > > combine the patches and remove the dead code when it becomes dead. I will > > work on that. Actually some of the code in patch 3 applies to patch 1 and > > some applies to patch 2. So, it will not be simply combining patch 2 and 3. > > On second thought, the cleanups in patch 3 only apply to patch 2. So, just > combining those two patches with a slightly updated commit message as below > makes the most sense. All confused. I dropped the current version, let's try again. This: > Hoping to get more comments on the overall direction and locking changes > of this and the previous patch. and this: > Cc: > Fixes: ebed4bfc8da8 ("hugetlb: fix absurd HugePages_Rsvd") make for a hot combination. Could people please prioritize review of this code? Perhaps a refresh and resend is in order.