From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f54.google.com ([209.85.221.54]:44718 "EHLO mail-wr1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728835AbeLTURN (ORCPT ); Thu, 20 Dec 2018 15:17:13 -0500 Received: by mail-wr1-f54.google.com with SMTP id z5so3046890wrt.11 for ; Thu, 20 Dec 2018 12:17:12 -0800 (PST) Date: Thu, 20 Dec 2018 20:17:09 +0000 From: Sudip Mukherjee To: gregkh@linuxfoundation.org Cc: bart.vanassche@wdc.com, jgg@mellanox.com, stable@vger.kernel.org Subject: Re: FAILED: patch "[PATCH] ib_srpt: Fix a use-after-free in __srpt_close_all_ch()" failed to apply to 4.14-stable tree Message-ID: <20181220201709.hoauiiswzz2fdgls@debian> References: <153631219125175@kroah.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="zejsnsxjtqwxwlib" Content-Disposition: inline In-Reply-To: <153631219125175@kroah.com> Sender: stable-owner@vger.kernel.org List-ID: --zejsnsxjtqwxwlib Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Greg, On Fri, Sep 07, 2018 at 11:23:11AM +0200, gregkh@linuxfoundation.org wrote: > > The patch below does not apply to the 4.14-stable tree. > If someone wants it applied there, or to any other stable or longterm > tree, then please email the backport, including the original git commit > id to . The attached backported patch will apply to 4.14-stable tree. -- Regards Sudip --zejsnsxjtqwxwlib Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-ib_srpt-Fix-a-use-after-free-in-__srpt_close_all_ch.patch" >>From f2035581dc9d3d13c941f37e11194b0ed59ccaef Mon Sep 17 00:00:00 2001 From: Bart Van Assche Date: Mon, 2 Jul 2018 14:08:45 -0700 Subject: [PATCH] ib_srpt: Fix a use-after-free in __srpt_close_all_ch() commit 14d15c2b278011056482eb015dff89f9cbf2b841 upstream BUG: KASAN: use-after-free in srpt_set_enabled+0x1a9/0x1e0 [ib_srpt] Read of size 4 at addr ffff8801269d23f8 by task check/29726 CPU: 4 PID: 29726 Comm: check Not tainted 4.18.0-rc2-dbg+ #4 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.0.0-prebuilt.qemu-project.org 04/01/2014 Call Trace: dump_stack+0xa4/0xf5 print_address_description+0x6f/0x270 kasan_report+0x241/0x360 __asan_load4+0x78/0x80 srpt_set_enabled+0x1a9/0x1e0 [ib_srpt] srpt_tpg_enable_store+0xb8/0x120 [ib_srpt] configfs_write_file+0x14e/0x1d0 [configfs] __vfs_write+0xd2/0x3b0 vfs_write+0x101/0x270 ksys_write+0xab/0x120 __x64_sys_write+0x43/0x50 do_syscall_64+0x77/0x230 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7f235cfe6154 Fixes: aaf45bd83eba ("IB/srpt: Detect session shutdown reliably") Signed-off-by: Bart Van Assche Cc: Signed-off-by: Jason Gunthorpe Signed-off-by: Sudip Mukherjee --- drivers/infiniband/ulp/srpt/ib_srpt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c index 60105ba77889..47f3f562d86f 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -1775,8 +1775,8 @@ static void __srpt_close_all_ch(struct srpt_device *sdev) list_for_each_entry(ch, &sdev->rch_list, list) { if (srpt_disconnect_ch(ch) >= 0) - pr_info("Closing channel %s-%d because target %s has been disabled\n", - ch->sess_name, ch->qp->qp_num, + pr_info("Closing channel %s because target %s has been disabled\n", + ch->sess_name, sdev->device->name); srpt_close_ch(ch); } -- 2.11.0 --zejsnsxjtqwxwlib--