From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E845C43387 for ; Thu, 27 Dec 2018 22:52:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D3B120675 for ; Thu, 27 Dec 2018 22:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545951135; bh=6p4Sj9IekJL1KKrFd71jZ1g7wgyQquXlLPqFm86GYTE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=AcIj8QNM0dN4pl8h5F3xqI9rfawVcNfppFqKXJc+DcNtOr0pTB91IDzLEB6d8PZoS NcbCRUuZ08EAPkEhNyXS5UE+dP02h5Lic1kNI82NY37VYqJJI6NQTe+8pPkvK7F9cC dkYtLSwCIaKqq1pBriHkpuvg9pjwCYudQZcILGmk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730733AbeL0WwL (ORCPT ); Thu, 27 Dec 2018 17:52:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:43512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730062AbeL0WwL (ORCPT ); Thu, 27 Dec 2018 17:52:11 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1ACFC208E4; Thu, 27 Dec 2018 22:52:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545951130; bh=6p4Sj9IekJL1KKrFd71jZ1g7wgyQquXlLPqFm86GYTE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yBD8IzDq/JeRHNgZC+Opw3/Ek2u6IvOKL7sVjE0IPOYzAf7vju3ZitVjL7suzRYUl u3hfbWAheovuU4E9qsk2PN/0k/92fuEEFm03Cd8LT107ohzJhsqVZjTigDudpUvWwC zsSBK+S67D6COoG2cUERhvANvm9Pj+ZS7z2fdAK0= Date: Thu, 27 Dec 2018 17:52:08 -0500 From: Sasha Levin To: Christian Borntraeger Cc: Martin Schwidefsky , stable@vger.kernel.org, linux-s390 , linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: 4.19.5 and later has tons of false messages "BUG: non-zero pgtables_bytes on freeing mm: -16384" Message-ID: <20181227225208.GW86645@sasha-vm> References: <4e58571e-1991-4a70-7012-ff9dd76afee3@de.ibm.com> <1d6288dd-a65b-463a-8aeb-33904dafa9cc@de.ibm.com> <20181227210136.GV86645@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Dec 27, 2018 at 10:06:09PM +0100, Christian Borntraeger wrote: > > >On 12/27/2018 10:01 PM, Sasha Levin wrote: >> On Thu, Dec 27, 2018 at 10:28:56AM +0100, Christian Borntraeger wrote: >>> >>> >>> On 27.12.2018 10:13, Christian Borntraeger wrote: >>>> Martin, >>>> >>>> Right now you get a message >>>> "BUG: non-zero pgtables_bytes on freeing mm: -16384" >>>> for EVERY process that exits in 4.19.5 and later. >>>> >>>> bisect points to >>>> commit 4136161d676a93fc8df6bdb80d720c15522d6c24 >>>> Author: Martin Schwidefsky >>>> Date:   Mon Oct 15 11:09:16 2018 +0200 >>>> >>>>     s390/mm: fix mis-accounting of pgtable_bytes >>>> >>>>     [ Upstream commit e12e4044aede97974f2222eb7f0ed726a5179a32 ] >>>> >>>> Turns out that this patch requires several dependencies so the autoselection of this >>>> patch was missing that. >>>> >>>> Can we either revert this patch or add the dependencies? >>>> >>>> Christian >>>> >>> >>> It seems that adding >>> >>> commit 6d212db11947ae5464e4717536ed9faf61c01e86 ("mm: add mm_pxd_folded checks to pgtable_bytes accounting functions") >>> fixes the issue. >> >> I've queued 6d212db11947 for 4.19 for now, thank you. > >Not sure, but you might need >1071fc5779d98 mm: introduce mm_[p4d|pud|pmd]_folded >a8874e7e8a889 mm: make the __PAGETABLE_PxD_FOLDED defines non-empty > >to avoid compile errors on !s390. Queued those for 4.19 as well, build looks clean. -- Thanks, Sasha