From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 768F5C43387 for ; Thu, 3 Jan 2019 08:23:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40FE2208E3 for ; Thu, 3 Jan 2019 08:23:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727804AbfACIXh (ORCPT ); Thu, 3 Jan 2019 03:23:37 -0500 Received: from mga12.intel.com ([192.55.52.136]:45984 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbfACIXh (ORCPT ); Thu, 3 Jan 2019 03:23:37 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2019 00:23:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,434,1539673200"; d="scan'208";a="131159306" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga002.fm.intel.com with SMTP; 03 Jan 2019 00:23:34 -0800 Received: by lahna (sSMTP sendmail emulation); Thu, 03 Jan 2019 10:23:33 +0200 Date: Thu, 3 Jan 2019 10:23:33 +0200 From: Mika Westerberg To: stanley.chu@mediatek.com Cc: linux-scsi@vger.kernel.org, wsd_upstream@mediatek.com, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, kuohong.wang@mediatek.com, stable@vger.kernel.org Subject: Re: [PATCH v2 1/1] scsi: Synchronize request queue PM status only on successful resume Message-ID: <20190103082333.GL2469@lahna.fi.intel.com> References: <1546498395-4184-1-git-send-email-stanley.chu@mediatek.com> <1546498395-4184-3-git-send-email-stanley.chu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1546498395-4184-3-git-send-email-stanley.chu@mediatek.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi, On Thu, Jan 03, 2019 at 02:53:15PM +0800, stanley.chu@mediatek.com wrote: > From: Stanley Chu > > The commit 356fd2663cff ("scsi: Set request queue runtime PM status > back to active on resume") fixed up the inconsistent RPM status between > request queue and device. However changing request queue RPM status > shall be done only on successful resume, otherwise status may be still > inconsistent as below, > > Request queue: RPM_ACTIVE > Device: RPM_SUSPENDED > > This ends up soft lockup because requests can be submitted to > underlying devices but those devices and their required resource > are not resumed. It would be good to add some example of the soft lockup you are seeing here. > Fixes: 356fd2663cff ("scsi: Set request queue runtime PM status > back to active on resume") You don't need to wrap this. The change itself looks fine.