From: Michal Kubecek <mkubecek@suse.cz>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
ieatmuttonchuan@gmail.com, meissner@suse.de,
linux-can@vger.kernel.org, linux-stable <stable@vger.kernel.org>
Subject: Re: [PATCH] can: gw: ensure DLC boundaries after CAN frame modification
Date: Fri, 4 Jan 2019 10:01:43 +0100 [thread overview]
Message-ID: <20190104090143.GD28932@unicorn.suse.cz> (raw)
In-Reply-To: <715d1d82-af65-9344-dcce-0ddcace50274@hartkopp.net>
On Thu, Jan 03, 2019 at 10:03:47PM +0100, Oliver Hartkopp wrote:
> 1. I'm still using the test "if (cf->can_dlc > 8)" with a proper comment as
> CAN_MAX_DLC and CAN_MAX_DLEN are not defined in Linux stable 3.2 - so that
> we can apply the patch to all versions of gw.c
I may be biased as substantial part of my work consists of trying to
understand unfamiliar code written by other people but I believe
readability of the code is more important than avoiding a bit of work
with backport to older stable branches.
Michal Kubecek
next prev parent reply other threads:[~2019-01-04 9:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 12:26 [PATCH] can: gw: ensure DLC boundaries after CAN frame modification Oliver Hartkopp
2019-01-03 14:01 ` Michal Kubecek
2019-01-03 19:31 ` Oliver Hartkopp
2019-01-03 20:33 ` Michal Kubecek
2019-01-03 21:03 ` Oliver Hartkopp
2019-01-04 9:01 ` Michal Kubecek [this message]
2019-01-04 9:28 ` Oliver Hartkopp
-- strict thread matches above, loose matches on Subject: below --
2019-01-04 9:13 Oliver Hartkopp
2019-01-04 10:31 ` Michal Kubecek
2019-01-04 10:57 ` Oliver Hartkopp
2019-01-04 14:16 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104090143.GD28932@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=davem@davemloft.net \
--cc=ieatmuttonchuan@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=meissner@suse.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).