From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E75C43387 for ; Mon, 7 Jan 2019 12:36:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 713F720859 for ; Mon, 7 Jan 2019 12:36:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546864562; bh=GxRqCTkHQ1OeMbR4nuuXhqIClCNiFebthZZ9DA6OSNA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HA7w7sG5ln3EL+/K1w8KR1An/VXDmwDzHCasXxeC7/wcrpwLl28izJnA13h7UjwIE Ie0vcXpd5ejvch1UiGXhPLYr7/uL8qOWPrPV6yL6gQQrn7xfHOw5HPv154JQGQjAkM AOFVTrpQsz27ItLsw7k8KkvVKo0EYIOJry83/420= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727195AbfAGMf4 (ORCPT ); Mon, 7 Jan 2019 07:35:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:50332 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727182AbfAGMfz (ORCPT ); Mon, 7 Jan 2019 07:35:55 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7294D218AD; Mon, 7 Jan 2019 12:35:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546864555; bh=GxRqCTkHQ1OeMbR4nuuXhqIClCNiFebthZZ9DA6OSNA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=osqWPGTqPT6UyOphknijjeciZp5Yyj2JqMNZ5bdill7h2AxeJPeJGn26FxSlvvHXc 2bxoiGrTx/GzOkxd58hL5OG6RzBNZOkWIFdn8nqCXnNcLN6hDFTi11slXPyXaKdGx4 LHFZ8rjqp2KeN7JjMALWjSbakvABkqdr6XZ39d8A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Takashi Iwai Subject: [PATCH 4.20 048/145] staging: bcm2835-audio: double free in init error path Date: Mon, 7 Jan 2019 13:31:25 +0100 Message-Id: <20190107104443.713804379@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107104437.308206189@linuxfoundation.org> References: <20190107104437.308206189@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter commit 649496b603000135683ee76d7ea499456617bf17 upstream. We free instance here and in the caller. It should be only the caller which handles it. Fixes: d7ca3a71545b ("staging: bcm2835-audio: Operate non-atomic PCM ops") Signed-off-by: Dan Carpenter Reviewed-by: Takashi Iwai Cc: stable Signed-off-by: Greg Kroah-Hartman --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c @@ -143,7 +143,6 @@ vc_vchi_audio_init(VCHI_INSTANCE_T vchi_ dev_err(instance->dev, "failed to open VCHI service connection (status=%d)\n", status); - kfree(instance); return -EPERM; }