From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B69B7C43387 for ; Mon, 7 Jan 2019 12:43:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85B2D2183E for ; Mon, 7 Jan 2019 12:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546865002; bh=0AVrYq4m714zdNnekI7D7EgRIW/5jirYlSS5GfdJ6bc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BkWJAaq0+1z/1tw/k6eOTiFwPNNMUWHZj/u5TVugWcZJ9oaw7lwORtx3Fmk32kA8J QfOvsnaYC4ePfUNPLjynWRcWI8G2qw+4ve6vxlqBvDv4TDj1ukDinKW2CCiWJjQj2R VirN4JNOp2SCcWwXjNnO1letu4I17rbbv7h+cl/Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727674AbfAGMnQ (ORCPT ); Mon, 7 Jan 2019 07:43:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:59092 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727806AbfAGMnP (ORCPT ); Mon, 7 Jan 2019 07:43:15 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 146F920449; Mon, 7 Jan 2019 12:43:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546864994; bh=0AVrYq4m714zdNnekI7D7EgRIW/5jirYlSS5GfdJ6bc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n7RgYDIXeT6ZmekjrPCMN7L9EwNp9CfTRgX6T9iHZ0cd7ffiuyBLw5BMJmpnHOEV7 9CQI1rBsrxcnshAnsxNVX3RmJOzTaOG1ptTd5H14FQxvWA62C0pj6aJJJhr0+fh7hP Q2J9F8t4UCLm394ErBKZFypj3CeTwRzgsNw1KmvE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luca Ceresoli , Sakari Ailus , Mauro Carvalho Chehab Subject: [PATCH 4.20 113/145] media: imx274: fix stack corruption in imx274_read_reg Date: Mon, 7 Jan 2019 13:32:30 +0100 Message-Id: <20190107104451.962712193@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107104437.308206189@linuxfoundation.org> References: <20190107104437.308206189@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Luca Ceresoli commit cea8c0077d6cf3a0cea2f18a8e914af78d46b2ff upstream. imx274_read_reg() takes a u8 pointer ("reg") and casts it to pass it to regmap_read(), which takes an unsigned int pointer. This results in a corrupted stack and random crashes. Fixes: 0985dd306f72 ("media: imx274: V4l2 driver for Sony imx274 CMOS sensor") Cc: stable@vger.kernel.org # for 4.15 and up Signed-off-by: Luca Ceresoli Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/i2c/imx274.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/drivers/media/i2c/imx274.c +++ b/drivers/media/i2c/imx274.c @@ -619,16 +619,19 @@ static int imx274_write_table(struct sti static inline int imx274_read_reg(struct stimx274 *priv, u16 addr, u8 *val) { + unsigned int uint_val; int err; - err = regmap_read(priv->regmap, addr, (unsigned int *)val); + err = regmap_read(priv->regmap, addr, &uint_val); if (err) dev_err(&priv->client->dev, "%s : i2c read failed, addr = %x\n", __func__, addr); else dev_dbg(&priv->client->dev, "%s : addr 0x%x, val=0x%x\n", __func__, - addr, *val); + addr, uint_val); + + *val = uint_val; return err; }