From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 458D3C43387 for ; Mon, 7 Jan 2019 13:11:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1416D2089F for ; Mon, 7 Jan 2019 13:11:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546866714; bh=IrZD1v1KjTZ8k5//f8B5KiDQZi0vtrLpePTkTbvfYKw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wNjuIK62Huie1XEJa0QaD7o1rxAX+ffIDWZpQjmVMLyYYzsOur+k3I7Sj0y+7s/pL 54DG36RpJ1UY1jBmAtsA7MJ8gi7e/YGPCJ0cqVsb6pi7BtNSzULa2nmx/a9r0no3wd qxZFqL1qzz+1SL/isDYgiSUvMGi6dMhowqZscx88= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729844AbfAGNLr (ORCPT ); Mon, 7 Jan 2019 08:11:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:55194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729937AbfAGNIH (ORCPT ); Mon, 7 Jan 2019 08:08:07 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A4F1A217D4; Mon, 7 Jan 2019 13:08:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546866487; bh=IrZD1v1KjTZ8k5//f8B5KiDQZi0vtrLpePTkTbvfYKw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wse1zzN1bEIdN+kl/3lviL07T42nTMh++ynUwtgcuTWeDDCShdi5g2RtQDT3uFx01 pw5bpsDFu+C9ItJ1jQKz9g68v7BiF3AqVLnV8j+ctcDt00WFFLo5AwZQOYzyveOpxK T6P7E1YOS2ZjtfdwYYe7gOEk1+D0TPim8kGTi5/Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Maurizio Lombardi , Theodore Tso , stable@kernel.org Subject: [PATCH 4.9 47/71] ext4: missing unlock/put_page() in ext4_try_to_write_inline_data() Date: Mon, 7 Jan 2019 13:33:16 +0100 Message-Id: <20190107105335.401905876@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107105330.280153213@linuxfoundation.org> References: <20190107105330.280153213@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maurizio Lombardi commit 132d00becb31e88469334e1e62751c81345280e0 upstream. In case of error, ext4_try_to_write_inline_data() should unlock and release the page it holds. Fixes: f19d5870cbf7 ("ext4: add normal write support for inline data") Cc: stable@kernel.org # 3.8 Signed-off-by: Maurizio Lombardi Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/inline.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/fs/ext4/inline.c +++ b/fs/ext4/inline.c @@ -702,8 +702,11 @@ int ext4_try_to_write_inline_data(struct if (!PageUptodate(page)) { ret = ext4_read_inline_page(inode, page); - if (ret < 0) + if (ret < 0) { + unlock_page(page); + put_page(page); goto out_up_read; + } } ret = 1;