From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40C84C43387 for ; Mon, 7 Jan 2019 13:12:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1222920645 for ; Mon, 7 Jan 2019 13:12:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546866744; bh=zK+AYwJmVpysIuJ2lwppN+trx9FLy/0R2hjWuo8xexA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=CvGyAy0nkiSTnMN+NgrUXTJ4GlzGstadinX4nUbB0qWaT+b7a4ynhDezBGrVrB2+l 35FdKSpl9m5t8L/kX/kPNQluoEuyRwfc/Hfw5BuUFWYYkl8OqX/Xv70yn8+H9wbyHT Srp7qF2o/dJsBfLN2X1uBOVnvhv5xvywT0Emf9A0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728101AbfAGNMW (ORCPT ); Mon, 7 Jan 2019 08:12:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:52390 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730602AbfAGNEn (ORCPT ); Mon, 7 Jan 2019 08:04:43 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4836021855; Mon, 7 Jan 2019 13:04:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546866282; bh=zK+AYwJmVpysIuJ2lwppN+trx9FLy/0R2hjWuo8xexA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1j36HCZ8UHN1YOkr/nAho1HSqgIBtncvEDgivHCQ3EuFJRXFq+UwJx/JZj6YZZx5e SIdCi2MVBxk0hun1WLAAsFRnex49xwMzF3/GnEMba6dMyqP95LBhLSTClXoPcj+uao cMr8gwopVL6bMswf2v0pQUArzojlthB9huH2sTVU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans Verkuil , syzbot+ccf0a61ed12f2a7313ee@syzkaller.appspotmail.com, Mauro Carvalho Chehab Subject: [PATCH 4.14 088/101] media: v4l2-tpg: array index could become negative Date: Mon, 7 Jan 2019 13:33:16 +0100 Message-Id: <20190107105337.702427111@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107105330.372621917@linuxfoundation.org> References: <20190107105330.372621917@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hans Verkuil commit e5f71a27fa12c1a1b02ad478a568e76260f1815e upstream. text[s] is a signed char, so using that as index into the font8x16 array can result in negative indices. Cast it to u8 to be safe. Signed-off-by: Hans Verkuil Reported-by: syzbot+ccf0a61ed12f2a7313ee@syzkaller.appspotmail.com Cc: # for v4.7 and up Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c +++ b/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c @@ -1733,7 +1733,7 @@ typedef struct { u16 __; u8 _; } __packe unsigned s; \ \ for (s = 0; s < len; s++) { \ - u8 chr = font8x16[text[s] * 16 + line]; \ + u8 chr = font8x16[(u8)text[s] * 16 + line]; \ \ if (hdiv == 2 && tpg->hflip) { \ pos[3] = (chr & (0x01 << 6) ? fg : bg); \