From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F9F4C43612 for ; Mon, 7 Jan 2019 19:00:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF988206B7 for ; Mon, 7 Jan 2019 19:00:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="LmtL1BS4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726833AbfAGTAH (ORCPT ); Mon, 7 Jan 2019 14:00:07 -0500 Received: from mail-eopbgr130042.outbound.protection.outlook.com ([40.107.13.42]:53789 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728957AbfAGS7S (ORCPT ); Mon, 7 Jan 2019 13:59:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nkVW73J6nH8W9emQvWLeXyML1imIXrd+gqJDeXT2x5I=; b=LmtL1BS4hjC9l4AUcVXldhciSseCI/L6K+jewwMLsqlUj3KbyFSQeQhClASlHKnOMxOuqcHf1Z+zlRqE7YSW4tU+vkMQkU8fJ6JiheymoiWDsZYG/GonRAB6L1A8zfI1RoO1uoPGAVS3F09wXSah0tCRHSxyZhCcrDtAVB4bYcA= Received: from HE1PR05MB4601.eurprd05.prod.outlook.com (20.176.163.138) by HE1PR05MB4521.eurprd05.prod.outlook.com (20.176.163.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.6; Mon, 7 Jan 2019 18:59:13 +0000 Received: from HE1PR05MB4601.eurprd05.prod.outlook.com ([fe80::75a0:a89d:1227:7ed3]) by HE1PR05MB4601.eurprd05.prod.outlook.com ([fe80::75a0:a89d:1227:7ed3%5]) with mapi id 15.20.1495.011; Mon, 7 Jan 2019 18:59:13 +0000 From: Jason Gunthorpe To: Adit Ranadive CC: "dledford@redhat.com" , "linux-rdma@vger.kernel.org" , Pv-drivers , "stable@vger.kernel.org" Subject: Re: [PATCH for-rc] RDMA/vmw_pvrdma: Return the correct opcode when creating WR Thread-Topic: [PATCH for-rc] RDMA/vmw_pvrdma: Return the correct opcode when creating WR Thread-Index: AQHUprpEM1rwo1luj0eHCh2T5Z002KWkKKsA Date: Mon, 7 Jan 2019 18:59:13 +0000 Message-ID: <20190107185906.GD27929@mellanox.com> References: <1546887183-1238-1-git-send-email-aditr@vmware.com> In-Reply-To: <1546887183-1238-1-git-send-email-aditr@vmware.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: CO1PR15CA0097.namprd15.prod.outlook.com (2603:10b6:101:21::17) To HE1PR05MB4601.eurprd05.prod.outlook.com (2603:10a6:7:99::10) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jgg@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [174.3.196.123] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;HE1PR05MB4521;6:Jjmw4Hua34oERIFlDfuHVYLW6KGBJNwOT70rodJc0Fhplbkh3TLLgMHcjf4ow09W5Lao76PBuhoBGsbWn/hFjKLuj88EeaitdNJkSM/2W3j9EBM3/g+xTuCRXSQS98vI17O6wwEghdoH2JpSLChkZO2NDE4dQOkzDF5bJCgO+zo/6fBBjWK4KWkdsbW2/RT1QY0wznnR6PY+XrfEOlKe8ChpdvoDiEPcsrkqGWN8wIN79sVRkMOPowC+gBIPOIJrs3DkorhywxEy6MuCxD2vod3cfq0GcmZNdIDzigV73SeUftEKfdFsqfbOMSdY21Q4A48Sq1qYmQYj/VrMu3QyAfRKeJi8R3QMpDfmQnbbyvYOi/yM+aRN8751E5ktx4NSL1MNKls/KeAiPobu8oNz4jwPfTIEen3SeS9OAxXDNkF3qzoa+qSqVMY+fIBXaP3X3PcWuR62u7IEczoGCU+BXw==;5:YakSEMHp9Mlu2zGK3RmcHfECix8Reeql8P0YiI7s8ukDB3SvJeIKGFGaVothLp87JPChat6c7WEnhExDQrRuVBicGUUjhGi+iqDyy+yecM1CQfuigIi7xQnm5qyJjjgD7ew/KGcetYlUFTPj7YKwvwyGnCFNg1w1WTNaAaEinzCq/MpfTk9pltNttT72584l6jtzndIw+GtPfBPDQRtnqw==;7:QVEcnKfzOOz5tx3RhaLZnXROmLpAVBoxWxhc09/nfJEEuBJmF1S51wJzMhHXCMqapeFTnA03EZJQ4/Zc9GBh1D8SwkRwB0/DMYBYfTHUCr9hLB1Vt4MpZXDk0EbwcMvIytFFDNqvxmnQFBHRhxEPvg== x-ms-office365-filtering-correlation-id: 11cf1822-7c9c-41e0-e179-08d674d236bb x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020);SRVR:HE1PR05MB4521; x-ms-traffictypediagnostic: HE1PR05MB4521: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(93006095)(93001095)(3231475)(944501520)(52105112)(3002001)(10201501046)(6055026)(6041310)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095);SRVR:HE1PR05MB4521;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB4521; x-forefront-prvs: 0910AAF391 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(366004)(346002)(376002)(396003)(136003)(189003)(199004)(229853002)(5660300001)(1076003)(6506007)(6436002)(81166006)(76176011)(6916009)(476003)(81156014)(6246003)(2906002)(386003)(478600001)(53936002)(316002)(6486002)(8676002)(256004)(68736007)(14454004)(86362001)(4326008)(7736002)(66066001)(305945005)(26005)(8936002)(14444005)(102836004)(97736004)(186003)(99286004)(6512007)(54906003)(33656002)(25786009)(446003)(52116002)(105586002)(2616005)(71190400001)(71200400001)(486006)(106356001)(6116002)(3846002)(36756003)(11346002);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR05MB4521;H:HE1PR05MB4601.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: /Qk428GpIcKHkMtDKT/EtPpMpipg/jv+yQatSu2h7igrfo5Dqp+N+HJDHIwOwVfDn65o93hljex/gH2e7ZzIcrKgIExrzoxLQo4YHr7U3I/Dql16Nd49RMKrnjFWYKsT2mrXkyiD8Wn4Ayqw3TrJT8tJHQ9J8GXJF0KVAP9f996oCa56Hy5eFLmUKnws92wgR0gy5Z0RXuTSu5I279mKWevUNqScf0JZe0L5oslvqOHaS7qeB0SXs7I+U45c2RpJt20efu3BwxaaUcZQ2TpOaKeqTcAO5/qVustVZAEeQBAooyIkZNJ2Ks7lKNtpzih0 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <5C4701467F680C47B780E75A543C6E58@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11cf1822-7c9c-41e0-e179-08d674d236bb X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jan 2019 18:59:12.9730 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB4521 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jan 07, 2019 at 06:53:24PM +0000, Adit Ranadive wrote: > From: Adit Ranadive >=20 > Since the IB_WR_REG_MR opcode value changed, set some of the PVRDMA devic= e > opcodes explicitly. >=20 > Reported-by: Ruishuang Wang > Fixes: 9a59739bd01f ("IB/rxe: Revise the ib_wr_opcode enum") > Cc: stable@vger.kernel.org > Reviewed-by: Bryan Tan > Reviewed-by: Ruishuang Wang > Reviewed-by: Vishnu Dasa > Signed-off-by: Adit Ranadive > --- > drivers/infiniband/hw/vmw_pvrdma/pvrdma.h | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) So naughty!! How many other places in this driver are assuming the intenal IB constants are stable? Did you audit for other cases? =20 > diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma.h b/drivers/infiniba= nd/hw/vmw_pvrdma/pvrdma.h > index 42b8685c997e..c2ed09e66d2b 100644 > --- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma.h > +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma.h > @@ -427,7 +427,26 @@ static inline enum ib_qp_state pvrdma_qp_state_to_ib= (enum pvrdma_qp_state state) > =20 > static inline enum pvrdma_wr_opcode ib_wr_opcode_to_pvrdma(enum ib_wr_op= code op) > { > - return (enum pvrdma_wr_opcode)op; > + switch (op) { > + case IB_WR_LSO: > + return PVRDMA_WR_LSO; > + case IB_WR_SEND_WITH_INV: > + return PVRDMA_WR_SEND_WITH_INV; > + case IB_WR_RDMA_READ_WITH_INV: > + return PVRDMA_WR_RDMA_READ_WITH_INV; > + case IB_WR_LOCAL_INV: > + return PVRDMA_WR_LOCAL_INV; > + case IB_WR_REG_MR: > + return PVRDMA_WR_FAST_REG_MR; > + case IB_WR_MASKED_ATOMIC_CMP_AND_SWP: > + return PVRDMA_WR_MASKED_ATOMIC_CMP_AND_SWP; > + case IB_WR_MASKED_ATOMIC_FETCH_AND_ADD: > + return PVRDMA_WR_MASKED_ATOMIC_FETCH_AND_ADD; > + case IB_WR_REG_SIG_MR: > + return PVRDMA_WR_REG_SIG_MR; > + default: > + return (enum pvrdma_wr_opcode)op; No default, lets write them all out please. Jason