From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23A87C43387 for ; Mon, 7 Jan 2019 19:17:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D387B206B7 for ; Mon, 7 Jan 2019 19:17:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="GdoujdAI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726884AbfAGTR3 (ORCPT ); Mon, 7 Jan 2019 14:17:29 -0500 Received: from mail-eopbgr00041.outbound.protection.outlook.com ([40.107.0.41]:34389 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726392AbfAGTR3 (ORCPT ); Mon, 7 Jan 2019 14:17:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HYDv003vL1u3Vb3giZLXY3ps6k6smKUj+w1wSBTT5BU=; b=GdoujdAIoRfoTpa/F/wg3fyh0VOcxc68sGFIpc2SG5d1swmO/Kcmv0wE+32NmQOTz1IbLFlhkfZfdWkaGDUSXWdJ8paOpjAN4Gen7dMlRnyFg9bCeYVXA0K7aOfPx/T3+PAg5RMczmYqBOO2CcDYGHz9ej4zgb3TChANbeZXINE= Received: from HE1PR05MB4601.eurprd05.prod.outlook.com (20.176.163.138) by HE1PR05MB3260.eurprd05.prod.outlook.com (10.170.243.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.7; Mon, 7 Jan 2019 19:17:23 +0000 Received: from HE1PR05MB4601.eurprd05.prod.outlook.com ([fe80::75a0:a89d:1227:7ed3]) by HE1PR05MB4601.eurprd05.prod.outlook.com ([fe80::75a0:a89d:1227:7ed3%5]) with mapi id 15.20.1495.011; Mon, 7 Jan 2019 19:17:23 +0000 From: Jason Gunthorpe To: Adit Ranadive CC: "dledford@redhat.com" , "linux-rdma@vger.kernel.org" , Pv-drivers , "stable@vger.kernel.org" Subject: Re: [PATCH for-rc] RDMA/vmw_pvrdma: Return the correct opcode when creating WR Thread-Topic: [PATCH for-rc] RDMA/vmw_pvrdma: Return the correct opcode when creating WR Thread-Index: AQHUprpEM1rwo1luj0eHCh2T5Z002KWkKKsAgAACsQCAAAJjAA== Date: Mon, 7 Jan 2019 19:17:23 +0000 Message-ID: <20190107191716.GE27929@mellanox.com> References: <1546887183-1238-1-git-send-email-aditr@vmware.com> <20190107185906.GD27929@mellanox.com> <7015989d-38ae-a4fb-5ca9-a88837774738@vmware.com> In-Reply-To: <7015989d-38ae-a4fb-5ca9-a88837774738@vmware.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MWHPR14CA0070.namprd14.prod.outlook.com (2603:10b6:300:81::32) To HE1PR05MB4601.eurprd05.prod.outlook.com (2603:10a6:7:99::10) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jgg@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [174.3.196.123] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;HE1PR05MB3260;6:SB9G4jyTRL8D7c4beTfNaEhEEHU8vW7PA67nMkx+rcPThNNXv72b25nOR37RH2M/+ENhxzItekW62V2E/cjQ2qBgTO9tYBAc0Q86SnxsyT5JOy1j0fZ4RfrkIZ9FmJe7xgYw3YkKViW4TgCTbFGYlAgNtPUcbQnH6kXVTc6n6w1SpyiKNZUYRQ8mbDTZ9q72MO2qDmzP0SSm3Z5HLm/MjEN+EJ2azgaGM7za2fR1L/2LrkoziSiR0q8HD1kQsfA9kD/qZAJ5oMG0R7e14ZRJgnDT/4avQ6tTBA675hR37kfAtGCjBaLp1ikCZCnS/lkeWqURXXJ+I0ji+8UaIuraaqfvvnOPPdZ2EFVovRlf1tnRs/VOXt0jwVP2Ul2rLHS9iRRsinMH1+5g7/+XJ2dyIl/OGh+gEpQSprAR5zzLtt3Y3GOVsSOk5+8mJHrJxGoqR/TPP8ouYnLtxflkjqzeVA==;5:zTpFU+SaKanPkLHGtQcFbCt6FHesmWpa4sD47jhO2gh6lbjF4nG9iKY2gvnONgAxmnd6YXjCehPaKCKxNVyDrW7d+F3hQLzDyr+5CsqxzXVCgH3xytNUScFpexqRQUSQpwKKwnb9p280Qw80hUGlgrXb6HaHvTWZA4arsnpn+UhmczsyKOAYZUKgSKaOPztFQ3W6I4x9XIv+MQWR9o6+TQ==;7:4VGxdooJj/y3xOY5VmNHHMWka3K/i0ek0Rx/OjyaXi+TcGpezUg1nzGutRtUSJ/64AWaLOztAKlw1+Kbia4Awp2P/mwCBd0xeBQICT1PmN9f67TjKrV8PRvsHy25lvtCSNkHZeuFbFfa+6RaKUBeBA== x-ms-office365-filtering-correlation-id: 48dd4b4f-20aa-4233-90f3-08d674d4c0c3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020);SRVR:HE1PR05MB3260; x-ms-traffictypediagnostic: HE1PR05MB3260: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(10201501046)(93006095)(93001095)(3231475)(944501520)(52105112)(3002001)(6055026)(6041310)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095);SRVR:HE1PR05MB3260;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB3260; x-forefront-prvs: 0910AAF391 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(136003)(346002)(396003)(366004)(376002)(39860400002)(199004)(189003)(11346002)(476003)(6486002)(6436002)(2616005)(446003)(81166006)(478600001)(81156014)(14444005)(14454004)(8936002)(33656002)(8676002)(256004)(106356001)(53936002)(6512007)(25786009)(36756003)(7736002)(2906002)(486006)(305945005)(6246003)(105586002)(66066001)(6116002)(26005)(186003)(386003)(53546011)(3846002)(52116002)(5660300001)(4326008)(102836004)(6506007)(229853002)(97736004)(1076003)(54906003)(316002)(76176011)(71190400001)(71200400001)(68736007)(6916009)(86362001)(99286004);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR05MB3260;H:HE1PR05MB4601.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 0f2T/593PzH5cKg5A8uGKFyaR8xJLQ1scSkqPaoSQ+RH/+vPueJqnkGlVErv6KX61X6cbQAnPDfQMSRx4tGufrMIIjEdbEnecnjzRND0I+qb67zncWeaSc0QFY5kL0NVUCuTOwQw8ahHozF8AytP2Rj3sqzjxSmURlYhZgiTZC+UNhC7Hd6jE7tCJM/i+0Ft60jttFxxyDoMZ4ykGiBJYgFeDdhfhU3ea115fklfBdT08O9bhfi0v1xHVdqowF6hYvdnqodDe0WBmzK67xrFSQC6KuvDfqwm+lXjPBGY7CV7uIIodS50sJ4O8WBZe3lF spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <3F4D33F7232D5C429ACB49BBC55BED05@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48dd4b4f-20aa-4233-90f3-08d674d4c0c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jan 2019 19:17:23.5424 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB3260 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jan 07, 2019 at 07:08:36PM +0000, Adit Ranadive wrote: > On 1/7/19 10:59 AM, Jason Gunthorpe wrote: > > On Mon, Jan 07, 2019 at 06:53:24PM +0000, Adit Ranadive wrote: > >> From: Adit Ranadive > >> > >> Since the IB_WR_REG_MR opcode value changed, set some of the PVRDMA de= vice > >> opcodes explicitly. > >> > >> Reported-by: Ruishuang Wang > >> Fixes: 9a59739bd01f ("IB/rxe: Revise the ib_wr_opcode enum") > >> Cc: stable@vger.kernel.org > >> Reviewed-by: Bryan Tan > >> Reviewed-by: Ruishuang Wang > >> Reviewed-by: Vishnu Dasa > >> Signed-off-by: Adit Ranadive > >> drivers/infiniband/hw/vmw_pvrdma/pvrdma.h | 21 ++++++++++++++++++++- > >> 1 file changed, 20 insertions(+), 1 deletion(-) > >=20 > > So naughty!! How many other places in this driver are assuming the > > intenal IB constants are stable? > >=20 > > Did you audit for other cases? >=20 > Lots of places. Though its the values shared with userspace, like QP type= s, > IB MTUs, etc. Unless you foresee changes to those ..=20 Constants declared in the include/uapi header should be OK, but you still need to check that the constants you are using are actually in that header and either recode them or move them into uapi, as appropriate. When constants get moved we may find more mistakes like this that cause the kernel view to change. Jason