From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 460C3C43387 for ; Mon, 7 Jan 2019 23:28:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F109B2070B for ; Mon, 7 Jan 2019 23:28:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="XfwFj/G3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726689AbfAGX2a (ORCPT ); Mon, 7 Jan 2019 18:28:30 -0500 Received: from mail-eopbgr130088.outbound.protection.outlook.com ([40.107.13.88]:12944 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726668AbfAGX2a (ORCPT ); Mon, 7 Jan 2019 18:28:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kg5NYZ8Y1whCkpp1a4H5ag7zqNTY2SydPbnIISxarLw=; b=XfwFj/G3+8F2K1pjTMYb5O1teTQzFCnHdyDmmttRUR3fXwmJ6RlRDzjDK2bOGa3+MbI7JpoidSFUVaKTP6+/tloF1vGvTLXvWeoXlHsNqdfc0169i8Yuv0A4c5pT+LRXTSNr9jXr+nkGrbNg7/DlckiMHeLXh8WLzU1ib4Ov+zg= Received: from HE1PR05MB4601.eurprd05.prod.outlook.com (20.176.163.138) by HE1PR05MB3129.eurprd05.prod.outlook.com (10.170.242.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.6; Mon, 7 Jan 2019 23:28:22 +0000 Received: from HE1PR05MB4601.eurprd05.prod.outlook.com ([fe80::75a0:a89d:1227:7ed3]) by HE1PR05MB4601.eurprd05.prod.outlook.com ([fe80::75a0:a89d:1227:7ed3%5]) with mapi id 15.20.1495.011; Mon, 7 Jan 2019 23:28:22 +0000 From: Jason Gunthorpe To: Adit Ranadive CC: "dledford@redhat.com" , "linux-rdma@vger.kernel.org" , Pv-drivers , "stable@vger.kernel.org" Subject: Re: [PATCH v1 for-rc] RDMA/vmw_pvrdma: Return the correct opcode when creating WR Thread-Topic: [PATCH v1 for-rc] RDMA/vmw_pvrdma: Return the correct opcode when creating WR Thread-Index: AQHUpt/xUtLtTnPzR0q4VG8iPXfWc6Wkc5OA Date: Mon, 7 Jan 2019 23:28:22 +0000 Message-ID: <20190107232815.GP27929@mellanox.com> References: <1546903346-15461-1-git-send-email-aditr@vmware.com> In-Reply-To: <1546903346-15461-1-git-send-email-aditr@vmware.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MWHPR12CA0040.namprd12.prod.outlook.com (2603:10b6:301:2::26) To HE1PR05MB4601.eurprd05.prod.outlook.com (2603:10a6:7:99::10) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jgg@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [174.3.196.123] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;HE1PR05MB3129;6:BqI1j6DCIVthzYkjCFmg0VPVb+mMpzLhVZM25OdHinAwPK6t2TSYRu4omhaltRTOqcuhqp4/VeWKvyhiieRZkP4RZTbCfMP88r1WqSxiETJTAb8rt7P6wCFAye7CoI4dhEK6u1b3C1HDEg2SGO7rrST134ugNEddM6Ay3YDhscQKyuJR//12CLLWO6hcLGclVzajMi2EtAV1a4AZJqLsmCmWR0ElwSBmYeQRNIQHpmHPdhYGk9BoLyc2k4ITUHQwvAbmkzEbf5asPd1OiHg+teEl3SpIxcmBVm80R8YwlkiUiZT+pvD/3jDq1CIH0cud7CL6IamnEPumuStNAQCLggWIr2q71ZKdSl13+TlvRChZWEjm0T8cvtkpKCGVgnsGFPvYaj+WZ4z3gCGqtHchIho48GvDZdG1zBcb/I8Nu4ZyVJkTgXlor3FI7+Ui/uHlV7csyRRx9mXRrdyjFoXiQQ==;5:2kQZwQdVYLzdeHTLRBSG79D7oIY1tdh+jsONpjjxDi1iHkAr7smmw2BVT041EghPj0RRN3O7BCsHSnRj9PGiWQ/7LBIfiIaidIiAVRNGA2Wg5DXu5fXDug4veeMkKthqTugtyTsvcoBUmowmLB6W425X6k4BlpQFACDt1HhvHLI7bfCBa5tFEE63Pj8jUHSd8KtFUGbqJfJKP+5RIKWZgA==;7:6b2e9vcRJ4PuFXnemcBFr+cGe9uTqzeJ7GcUHowbTqJ+sZu/3uXMNBpaX8yjjMQxbkro5dV938FLdkh+9iQhRE7OnjWkPOHiN0rYgO3JXrDwzIhvXvBRvxkaOwflmnqqywDx5gwgVyUIFORZmBj+CQ== x-ms-office365-filtering-correlation-id: 9e19e80a-4538-4875-f5d8-08d674f7d06f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600109)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:HE1PR05MB3129; x-ms-traffictypediagnostic: HE1PR05MB3129: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231475)(944501520)(52105112)(6055026)(6041310)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095);SRVR:HE1PR05MB3129;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB3129; x-forefront-prvs: 0910AAF391 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(396003)(346002)(136003)(366004)(39860400002)(199004)(189003)(106356001)(2906002)(102836004)(478600001)(6116002)(3846002)(7736002)(97736004)(54906003)(36756003)(76176011)(6512007)(81156014)(81166006)(386003)(316002)(6916009)(8676002)(446003)(6506007)(11346002)(486006)(5660300001)(25786009)(476003)(229853002)(2616005)(8936002)(66066001)(256004)(4326008)(71190400001)(86362001)(105586002)(6486002)(71200400001)(26005)(1076003)(14444005)(99286004)(53936002)(14454004)(52116002)(68736007)(6246003)(33656002)(186003)(6436002)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR05MB3129;H:HE1PR05MB4601.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: RnaY2pr4on6uT4ocekh7GegXldFsoj5IwzkHpLRScfuiTesj6H8K26BgHPFa61P5vwjWeGN4pHatdTqTK70X3mTGyP0Lgg7TKrsoAR3k9ZSi7wiDMudVEPViypKVuQ49hU8HN4P9aE2wL71Tvb/nAt5lqnin2kS3AEjS1uM5pYupTS+pYfF166w8B8IO7wTdYNmntqW7aBy0TEQ35tG6ph2+u/Y8nPiievO+ywGJ3Czw2Y01AnGrQLSY5R7HRTUl4D8zIkVealeHnoA6Vqj8dlWUj0Gr4ZEQUYdWviFcg9takuZVeRXbmV94Z6jomDlD spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <1718D116A1DBD545BEC1A1439517F5C2@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e19e80a-4538-4875-f5d8-08d674f7d06f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jan 2019 23:28:22.2226 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB3129 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jan 07, 2019 at 11:23:05PM +0000, Adit Ranadive wrote: > From: Adit Ranadive >=20 > Since the IB_WR_REG_MR opcode value changed, let's set the PVRDMA > device opcodes explicitly. >=20 > Reported-by: Ruishuang Wang > Fixes: 9a59739bd01f ("IB/rxe: Revise the ib_wr_opcode enum") > Cc: stable@vger.kernel.org > Reviewed-by: Bryan Tan > Reviewed-by: Ruishuang Wang > Reviewed-by: Vishnu Dasa > Signed-off-by: Adit Ranadive > drivers/infiniband/hw/vmw_pvrdma/pvrdma.h | 43 +++++++++++++++++++++++++= ++++++ > 1 file changed, 43 insertions(+) >=20 > diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma.h b/drivers/infiniba= nd/hw/vmw_pvrdma/pvrdma.h > index 42b8685c997e..a85d7ba96d55 100644 > +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma.h > @@ -427,6 +427,49 @@ static inline enum ib_qp_state pvrdma_qp_state_to_ib= (enum pvrdma_qp_state state) > =20 > static inline enum pvrdma_wr_opcode ib_wr_opcode_to_pvrdma(enum ib_wr_op= code op) > { > + switch (op) { > + case IB_WR_RDMA_WRITE: > + return PVRDMA_WR_RDMA_WRITE; > + case IB_WR_RDMA_WRITE_WITH_IMM: > + return PVRDMA_WR_RDMA_WRITE_WITH_IMM; > + case IB_WR_SEND: > + return PVRDMA_WR_SEND; > + case IB_WR_SEND_WITH_IMM: > + return PVRDMA_WR_SEND_WITH_IMM; > + case IB_WR_RDMA_READ: > + return PVRDMA_WR_RDMA_READ; > + case IB_WR_ATOMIC_CMP_AND_SWP: > + return PVRDMA_WR_ATOMIC_CMP_AND_SWP; > + case IB_WR_ATOMIC_FETCH_AND_ADD: > + return PVRDMA_WR_ATOMIC_FETCH_AND_ADD; > + case IB_WR_LSO: > + return PVRDMA_WR_LSO; > + case IB_WR_SEND_WITH_INV: > + return PVRDMA_WR_SEND_WITH_INV; > + case IB_WR_RDMA_READ_WITH_INV: > + return PVRDMA_WR_RDMA_READ_WITH_INV; > + case IB_WR_LOCAL_INV: > + return PVRDMA_WR_LOCAL_INV; > + case IB_WR_REG_MR: > + return PVRDMA_WR_FAST_REG_MR; > + case IB_WR_MASKED_ATOMIC_CMP_AND_SWP: > + return PVRDMA_WR_MASKED_ATOMIC_CMP_AND_SWP; > + case IB_WR_MASKED_ATOMIC_FETCH_AND_ADD: > + return PVRDMA_WR_MASKED_ATOMIC_FETCH_AND_ADD; > + case IB_WR_REG_SIG_MR: > + return PVRDMA_WR_REG_SIG_MR; > + case IB_WR_RESERVED1: > + case IB_WR_RESERVED2: > + case IB_WR_RESERVED3: > + case IB_WR_RESERVED4: > + case IB_WR_RESERVED5: > + case IB_WR_RESERVED6: > + case IB_WR_RESERVED7: > + case IB_WR_RESERVED8: > + case IB_WR_RESERVED9: > + case IB_WR_RESERVED10: > + return (enum pvrdma_wr_opcode)op; > + } > return (enum pvrdma_wr_opcode)op; I ment it should always translate, not cast like this - if no translation is available then it should be a posting failure. Jason