From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E24A5C43387 for ; Tue, 8 Jan 2019 23:49:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98BDF2084D for ; Tue, 8 Jan 2019 23:49:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="i5BjllCG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728955AbfAHXtA (ORCPT ); Tue, 8 Jan 2019 18:49:00 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:34252 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728854AbfAHXtA (ORCPT ); Tue, 8 Jan 2019 18:49:00 -0500 Received: by mail-pf1-f194.google.com with SMTP id h3so2709911pfg.1 for ; Tue, 08 Jan 2019 15:48:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=L6B8RLotNur+AqqGZlXc9uv/HlWX/uKXMogKqDdxSzI=; b=i5BjllCGUutILveQ4ynVJQtIiWE3XsW2llmR3YQHi/FLyIFc9zRMszjIZk7Cq1wKAI IPYRxXfrJrBxqpHYqGlp/+3ik311F8h66ODZ/a3N23r6ki+lB3tFTxtTWgJTIMpLre0C 9sQOcyWZE6uM07bNQAgppG0iaHV7SKzPCFZEsIY4hTZgJn6OhKWx8j9azYeemSB/r8sl 81NNdcHJ1lFHZmYbMrj94JwOsPpAIRGxBiWuOA8nWmrDuNTM1zkGxBtMqiZl5FEWD4CW cdwBHOPRLhcZtJ/DPIRR+pYdHFPq5bpMXVB//+0Hfe1bb17P9+twn5b1j1akBH0Jy/h1 olTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=L6B8RLotNur+AqqGZlXc9uv/HlWX/uKXMogKqDdxSzI=; b=bxr/ntUQAMR2wN4vMQxBaVvsltsM5sIWT26ttOX1nK4S1S6pOtoRJupzd4Cdt+gM0G IvRmP0T9JsRE2r2QEMt+UhaoPSAyDExhlHNjgYkLI+/liMc2aM4QoHqMo6BjkT4Sb2uC x2IYWMmDFDdxWx4Sv4XNan2f4iC8sZMAN6ai9MC1k4Y6OREi3ZMVKcbEfGV7V6tzUYBl U55GhNcakev4DgF0Y3UItgDpQRyrS8mX5z2V9dwmYlrgoFqv1xDboALXCMVki88qa3mV 1JEscxqHtg4FuIFBxwLqIAkCQ3BmWPWUClzfwHYxLRfW1rOL8UkZ7pgtdvE+IAmaaIG4 1TDQ== X-Gm-Message-State: AJcUukemBuvXA+ifgGV6OBwGrDQenJ7/ff+810EYtLsadVg+D4NK8x25 fyl7ID+rf9+mlQmGvPabdXto1g== X-Google-Smtp-Source: ALg8bN5SYyZe+8YzylSCQ/taP3jgA10valUcSfTUexWPaTgo0CAUz+Muptx9wdwDsPwVnf0jWmBNJg== X-Received: by 2002:a63:d10:: with SMTP id c16mr3376859pgl.382.1546991339295; Tue, 08 Jan 2019 15:48:59 -0800 (PST) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id e23sm103938167pfh.68.2019.01.08.15.48.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Jan 2019 15:48:58 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1gh17B-0006NY-RY; Tue, 08 Jan 2019 16:48:57 -0700 Date: Tue, 8 Jan 2019 16:48:57 -0700 From: Jason Gunthorpe To: Adit Ranadive Cc: "dledford@redhat.com" , "linux-rdma@vger.kernel.org" , Pv-drivers , "stable@vger.kernel.org" Subject: Re: [PATCH v1 for-rc] RDMA/vmw_pvrdma: Return the correct opcode when creating WR Message-ID: <20190108234857.GC30436@ziepe.ca> References: <1546903346-15461-1-git-send-email-aditr@vmware.com> <20190107232815.GP27929@mellanox.com> <20190108031051.GC5336@ziepe.ca> <01aef10a-8b54-5ff5-0f90-d74d8c4c70cc@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01aef10a-8b54-5ff5-0f90-d74d8c4c70cc@vmware.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Jan 08, 2019 at 06:39:02PM +0000, Adit Ranadive wrote: > >> Not sure if I follow you. We can post a failure but that would be > >> in pvrdma_qp.c when it looks at the opcode returned from here. We > >> would have to handle all the IB enums here though if you don't want > >> a default case (you would get compiler warnings otherwise). > > > > You'd do something like > > > > default: > > return PVRDMA_WR_ERROR; > > > > And something, somewhere, should fail the posting. > > > > Jason > > > > Okay. So maybe something like this, would work: Yes, this is what I was thinking, please send a patch Jason