* [v4.9, v4.14] vhost/vsock: fix uninitialized vhost_vsock->guest_cid
@ 2019-01-07 22:49 Daniel Verkamp
2019-01-10 19:12 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Verkamp @ 2019-01-07 22:49 UTC (permalink / raw)
To: stable; +Cc: Stefan Hajnoczi
Please apply mainline commit a72b69dc083a931422cc8a5e33841aff7d5312f2
("vhost/vsock: fix uninitialized vhost_vsock->guest_cid") to the v4.9
and v4.14 stable branches.
I believe this is the root cause of an issue uncovered by applying
"vhost/vsock: fix use-after-free in network stack callers" in these
branches. I sometimes see a crash in hash_del_rcu() with vsock in the
call stack, and that call is protected by a newly-added check of
vsock->guest_cid, which was uninitialized before this commit.
v4.4 doesn't have vsock, and v4.19 already has this commit, so they
don't need to be fixed.
Thanks,
-- Daniel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [v4.9, v4.14] vhost/vsock: fix uninitialized vhost_vsock->guest_cid
2019-01-07 22:49 [v4.9, v4.14] vhost/vsock: fix uninitialized vhost_vsock->guest_cid Daniel Verkamp
@ 2019-01-10 19:12 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-01-10 19:12 UTC (permalink / raw)
To: Daniel Verkamp; +Cc: stable, Stefan Hajnoczi
On Mon, Jan 07, 2019 at 02:49:02PM -0800, Daniel Verkamp wrote:
> Please apply mainline commit a72b69dc083a931422cc8a5e33841aff7d5312f2
> ("vhost/vsock: fix uninitialized vhost_vsock->guest_cid") to the v4.9
> and v4.14 stable branches.
>
> I believe this is the root cause of an issue uncovered by applying
> "vhost/vsock: fix use-after-free in network stack callers" in these
> branches. I sometimes see a crash in hash_del_rcu() with vsock in the
> call stack, and that call is protected by a newly-added check of
> vsock->guest_cid, which was uninitialized before this commit.
Now queued up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-10 19:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-07 22:49 [v4.9, v4.14] vhost/vsock: fix uninitialized vhost_vsock->guest_cid Daniel Verkamp
2019-01-10 19:12 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).