From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02D82C43387 for ; Fri, 11 Jan 2019 14:21:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BDB542177B for ; Fri, 11 Jan 2019 14:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547216459; bh=Sqy42z9xIHQHfoDgApDEgNJrdrJQKchgtw4WdgNSZZk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=VbMYxaywLZ7/A1iZ3fDqpypimDpMqBuB853Y5rjX3WrM+17DVlNPXgUVoatyhwrGF 9ee+QTxg085vBSPXmgtKTunV4vcqY9jx2A8ogVGBoDAH2/jQzlA8JxrKAjb404yQZT ray9NrvvCmAovSGvXyat+Z8EM1gq9mJRsW1GILGY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388074AbfAKOUQ (ORCPT ); Fri, 11 Jan 2019 09:20:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:37906 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731443AbfAKOUP (ORCPT ); Fri, 11 Jan 2019 09:20:15 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F16972184A; Fri, 11 Jan 2019 14:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547216415; bh=Sqy42z9xIHQHfoDgApDEgNJrdrJQKchgtw4WdgNSZZk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZKgNcWKbBgNzRv+2aV1eL3hi+UcejBg07m/YX6x6iCMkEJ0f2C0xawh/pPdiBBW+a vCRHf5DwbaxgEjdkgYLVcstajenvQCJ/fhFrDTXY32pyi5d2VNDml/n0y1ZkXOwE6P de1iIWmI4fmu0ljGh3e9XYDkhDWEOq6CI1A9Tme0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Yan, Zheng" , Ilya Dryomov Subject: [PATCH 4.4 84/88] ceph: dont update importing caps mseq when handing cap export Date: Fri, 11 Jan 2019 15:08:53 +0100 Message-Id: <20190111131059.677677167@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190111131045.137499039@linuxfoundation.org> References: <20190111131045.137499039@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yan, Zheng commit 3c1392d4c49962a31874af14ae9ff289cb2b3851 upstream. Updating mseq makes client think importer mds has accepted all prior cap messages and importer mds knows what caps client wants. Actually some cap messages may have been dropped because of mseq mismatch. If mseq is left untouched, importing cap's mds_wanted later will get reset by cap import message. Cc: stable@vger.kernel.org Signed-off-by: "Yan, Zheng" Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- fs/ceph/caps.c | 1 - 1 file changed, 1 deletion(-) --- a/fs/ceph/caps.c +++ b/fs/ceph/caps.c @@ -3243,7 +3243,6 @@ retry: tcap->cap_id = t_cap_id; tcap->seq = t_seq - 1; tcap->issue_seq = t_seq - 1; - tcap->mseq = t_mseq; tcap->issued |= issued; tcap->implemented |= issued; if (cap == ci->i_auth_cap)