From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E633C43387 for ; Tue, 15 Jan 2019 16:40:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D7A320675 for ; Tue, 15 Jan 2019 16:40:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547570447; bh=/rhcauA8CMyoUinUgVnPJWcbmQozRc9ZHXJrnaX8+HA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JYI2mPa45eYApwVlCPwn6B30j34Mo5w9LluCNOjFfyyx/8KNiULZXca1fNUpiJM5I IoU+tO7MvMhvg/qjxMYwv1dK+x4LR5yN3d31H9nreLXerYDyfcsm1Nk2vU9A4OkArV mpb0wKOmH+aah5al4PX4nMZerYI/NIR1QldN4XkI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729108AbfAOQkq (ORCPT ); Tue, 15 Jan 2019 11:40:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:57240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730407AbfAOQkq (ORCPT ); Tue, 15 Jan 2019 11:40:46 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 35F3C2054F; Tue, 15 Jan 2019 16:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547570445; bh=/rhcauA8CMyoUinUgVnPJWcbmQozRc9ZHXJrnaX8+HA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rQhbeepwOccRsWLILT34XDMZekj7XX0xAQbYr1H4IMKW+zG+v9wXm0buILrbtN26k 6r2ia7yRLZx7/d9Vw8u3VsgjEbEN40IZTqqtfZdPjpX2357ZwwfYWLvRu0r6CEBzqB BsAouQlo6r97nrfA7xd/1xTGztRHRH8RbCMb/Z/Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Theodore Tso , stable@kernel.org Subject: [PATCH 4.14 25/27] ext4: track writeback errors using the generic tracking infrastructure Date: Tue, 15 Jan 2019 17:36:14 +0100 Message-Id: <20190115154903.116456934@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190115154901.189747728@linuxfoundation.org> References: <20190115154901.189747728@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Theodore Ts'o commit 95cb67138746451cc84cf8e516e14989746e93b0 upstream. We already using mapping_set_error() in fs/ext4/page_io.c, so all we need to do is to use file_check_and_advance_wb_err() when handling fsync() requests in ext4_sync_file(). Signed-off-by: Theodore Ts'o Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/ext4/fsync.c | 3 +++ 1 file changed, 3 insertions(+) --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c @@ -164,6 +164,9 @@ int ext4_sync_file(struct file *file, lo ret = err; } out: + err = file_check_and_advance_wb_err(file); + if (ret == 0) + ret = err; trace_ext4_sync_file_exit(inode, ret); return ret; }