From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C62CC43387 for ; Tue, 15 Jan 2019 16:57:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E0D7B20675 for ; Tue, 15 Jan 2019 16:56:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547571420; bh=G9plZ83p74gZRur3Bjpj1Yyn5at8ZKvQPL8hBUTLlUg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yzzXqwqDDb9PO6VfJoFmjlLBEjAwCDKy87SVEtJzngXMxijvJ+7i2PnMUJ7ff5O79 gkxcyRCXh6YZI//CJEDr/T7c3P/h2PicLiJizhaj83MQQbnhQonhFe2iV32JTebM/A scWq4HziIzvulI1aghZQHpJxdRYalwtG0iTggsRU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730816AbfAOQ4y (ORCPT ); Tue, 15 Jan 2019 11:56:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:58120 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732766AbfAOQlW (ORCPT ); Tue, 15 Jan 2019 11:41:22 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CCAC12054F; Tue, 15 Jan 2019 16:41:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547570482; bh=G9plZ83p74gZRur3Bjpj1Yyn5at8ZKvQPL8hBUTLlUg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hqX1ffb5ZuIqQbdA9WElQP4gsuwLJg5jyXY9jmfIitNsTu7ty1zn10B3wVVVY7r7S 1H3SutCRs7AsRqljvtxse7LiYsy4/Xz6lmgNbIC+T6dYA+0LmY25J7cX2lJfrsCY36 UAZQRrpJnAHMl1wCGRqfaZGYUWhyX0kASTvGHk6c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pavel Shilovsky , Jeff Layton , Steve French Subject: [PATCH 4.19 11/50] CIFS: Do not hide EINTR after sending network packets Date: Tue, 15 Jan 2019 17:35:47 +0100 Message-Id: <20190115154910.617716110@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190115154909.933241945@linuxfoundation.org> References: <20190115154909.933241945@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pavel Shilovsky commit ee13919c2e8d1f904e035ad4b4239029a8994131 upstream. Currently we hide EINTR code returned from sock_sendmsg() and return 0 instead. This makes a caller think that we successfully completed the network operation which is not true. Fix this by properly returning EINTR to callers. Cc: Signed-off-by: Pavel Shilovsky Reviewed-by: Jeff Layton Signed-off-by: Steve French Signed-off-by: Greg Kroah-Hartman --- fs/cifs/transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/cifs/transport.c +++ b/fs/cifs/transport.c @@ -378,7 +378,7 @@ smbd_done: if (rc < 0 && rc != -EINTR) cifs_dbg(VFS, "Error %d sending data on socket to server\n", rc); - else + else if (rc > 0) rc = 0; return rc;