From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8431C61CE4 for ; Sat, 19 Jan 2019 10:04:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C62B2086A for ; Sat, 19 Jan 2019 10:04:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="p2kamBKA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727729AbfASKEz (ORCPT ); Sat, 19 Jan 2019 05:04:55 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:57194 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727702AbfASKEy (ORCPT ); Sat, 19 Jan 2019 05:04:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QuyW4tb0h2+ggI7dINjxd67tnjKdDje35i+P/WBdLbk=; b=p2kamBKAzGOiN9bEOsAdJAp+d Nx0YLSCqkJOR0Gg7943AdkoTEYQX+Q3LZ7x18oTEux07jfBaESa+CU9eKpTN8XQuix9xBjbuFsd3w ywpVK32io60+gnjQvBzOJctFnNrVSx7azZ7YOB1e3N20hl3JZzEbcnW4kBiDjLHoNWHKbafL9kaMS ihkNUR096Pr1Icp7nm/LvR/IjBN3r9ijQvGShMmMzaxWbPf3Pj15WGhC5kqY7zNo9WMn0aWqt2BEF loW+qGTOq0XmQn/V42EndbbHIY1+GiUsZCwSuIowxiv+8ayLMDcxpRfzDUSj3rIV3m0RZWe5ZUQje 6TRFtnDLA==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gknUj-0007gK-0p; Sat, 19 Jan 2019 10:04:53 +0000 Date: Sat, 19 Jan 2019 02:04:52 -0800 From: Christoph Hellwig To: Bart Van Assche Cc: Jason Gunthorpe , Doug Ledford , linux-rdma@vger.kernel.org, Sergey Gorenko , Max Gurtovoy , Laurence Oberman , stable@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 2/2] RDMA/srp: Rework SCSI device reset handling Message-ID: <20190119100452.GC24246@infradead.org> References: <20190117002717.84686-1-bvanassche@acm.org> <20190117002717.84686-3-bvanassche@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190117002717.84686-3-bvanassche@acm.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org > + /* Check whether all requests have finished. */ > + blk_freeze_queue_start(q); > + time_left = blk_mq_freeze_queue_wait_timeout(q, 1 * HZ); > + blk_mq_unfreeze_queue(q); > > + return time_left > 0 ? SUCCESS : FAILED; This is entirely generic SCSI/block evel functionality. I'd rather have a new WAIT_FOR_FREEZE return value from ->eh_device_reset_handler and handle this in the SCSI midlayer.