From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4769C2F3D5 for ; Mon, 21 Jan 2019 14:16:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C66C20861 for ; Mon, 21 Jan 2019 14:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548080207; bh=7tbCnHWATkhPa98WT36bcE6R+wjoeH0VqDR+kE3Ya5g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=awLS9txC8MWKwGnoqXeEBErXehYESYSnJ9mlWfewaJ1pi8q917e8hx0iypM46t18+ qtbOnsn9SUXsOhwuTVIMImTLCXO7uSo4wPRMGNGlmbsGHWewHXoBVJruW2/LEimgDW RQxqfNKh/0NkEmUrBu0ms3GRhQ/3LwswUfnNzTi4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729616AbfAUOQl (ORCPT ); Mon, 21 Jan 2019 09:16:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:33816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729313AbfAUNu7 (ORCPT ); Mon, 21 Jan 2019 08:50:59 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 634592063F; Mon, 21 Jan 2019 13:50:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548078658; bh=7tbCnHWATkhPa98WT36bcE6R+wjoeH0VqDR+kE3Ya5g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CjJWC1qu4NfKxjPZ1c9PM/QvOMWbgeNR/jRmZ4Wz/IGbTZzlNVunMpNNz2wxtvch1 YTGYQc2IO7NCfW02oSUkIhEtX2B+ewBIAUKXU6S6Bwy7mUsmdjEix/yOmYf9f6iKXz 1EJuth3f1Y/StA63AHTSadJy5EXwWYKAzD2PWmKI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot , Ming Lei , Jan Kara , Tetsuo Handa , Jens Axboe Subject: [PATCH 4.20 109/111] loop: Fix double mutex_unlock(&loop_ctl_mutex) in loop_control_ioctl() Date: Mon, 21 Jan 2019 14:43:43 +0100 Message-Id: <20190121122507.074297753@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190121122455.819406896@linuxfoundation.org> References: <20190121122455.819406896@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tetsuo Handa commit 628bd85947091830a8c4872adfd5ed1d515a9cf2 upstream. Commit 0a42e99b58a20883 ("loop: Get rid of loop_index_mutex") forgot to remove mutex_unlock(&loop_ctl_mutex) from loop_control_ioctl() when replacing loop_index_mutex with loop_ctl_mutex. Fixes: 0a42e99b58a20883 ("loop: Get rid of loop_index_mutex") Reported-by: syzbot Reviewed-by: Ming Lei Reviewed-by: Jan Kara Signed-off-by: Tetsuo Handa Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- drivers/block/loop.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -2074,12 +2074,10 @@ static long loop_control_ioctl(struct fi break; if (lo->lo_state != Lo_unbound) { ret = -EBUSY; - mutex_unlock(&loop_ctl_mutex); break; } if (atomic_read(&lo->lo_refcnt) > 0) { ret = -EBUSY; - mutex_unlock(&loop_ctl_mutex); break; } lo->lo_disk->private_data = NULL;