From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79097C282C0 for ; Sat, 26 Jan 2019 01:18:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 490AF218F0 for ; Sat, 26 Jan 2019 01:18:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="nZ7+o64y"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="nZ7+o64y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726091AbfAZBSS (ORCPT ); Fri, 25 Jan 2019 20:18:18 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:52470 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725550AbfAZBSS (ORCPT ); Fri, 25 Jan 2019 20:18:18 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4AD1B60860; Sat, 26 Jan 2019 01:18:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1548465498; bh=WfC+jWMiJPAS9DhmBhwHcB1+JNl8tA0fsmEaDC7/ov8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nZ7+o64yn/+flz7+rSe6FXklhx8/2vfjY6+1n/3EHoCs21PTT10fJeJ2rWGae4Dud WvcvaQnFlc3RKcXAXa9iVMBrN8AE1d6c0YLKpR7vjBhPuSElAkePjJ1yYMKnG/mxtJ +CJIpoU7wdj7WhUeqXAZq44cma1iotwiw1o8DF1k= Received: from jackp-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jackp@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id BFBAD607DD; Sat, 26 Jan 2019 01:18:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1548465498; bh=WfC+jWMiJPAS9DhmBhwHcB1+JNl8tA0fsmEaDC7/ov8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nZ7+o64yn/+flz7+rSe6FXklhx8/2vfjY6+1n/3EHoCs21PTT10fJeJ2rWGae4Dud WvcvaQnFlc3RKcXAXa9iVMBrN8AE1d6c0YLKpR7vjBhPuSElAkePjJ1yYMKnG/mxtJ +CJIpoU7wdj7WhUeqXAZq44cma1iotwiw1o8DF1k= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BFBAD607DD Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=jackp@codeaurora.org Date: Fri, 25 Jan 2019 17:18:16 -0800 From: Jack Pham To: Sasha Levin Cc: Felipe Balbi , Greg Kroah-Hartman , stable@vger.kernel.org Subject: Re: [PATCH v2] usb: dwc3: gadget: Clear req->needs_extra_trb flag on cleanup Message-ID: <20190126011816.GD23243@jackp-linux.qualcomm.com> References: <20190110203955.10724-1-jackp@codeaurora.org> <20190116133553.B64662086D@mail.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190116133553.B64662086D@mail.kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Sasha, On Wed, Jan 16, 2019 at 01:35:52PM +0000, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: c6267a51639b usb: dwc3: gadget: align transfers to wMaxPacketSize. > > The bot has tested the following trees: v4.20.2, v4.19.15, v4.14.93. > > v4.20.2: Build failed! Errors: > drivers/usb/dwc3/gadget.c:180:5: error: ‘struct dwc3_request’ has no member named ‘needs_extra_trb’ > > v4.19.15: Build failed! Errors: > drivers/usb/dwc3/gadget.c:180:5: error: ‘struct dwc3_request’ has no member named ‘needs_extra_trb’ > > v4.14.93: Build failed! Errors: > drivers/usb/dwc3/gadget.c:185:5: error: ‘struct dwc3_request’ has no member named ‘needs_extra_trb’ > > > How should we proceed with this patch? I mentioned in my "cover" message of the patch that it needs a slight rewrite for -stable since the 'needs_extra_trb' was only introduced in v5.0-rc1. Now that my patch is in Linus's tree, I can send it separately for -stable; I'll fix up the commit text slightly to refer to the variables used before v5.0. Thanks, Jack -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project