From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC42C282C7 for ; Sat, 26 Jan 2019 18:19:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0CA1921903 for ; Sat, 26 Jan 2019 18:19:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548526756; bh=vrsklQzt6XFm0nxumpI52ueEqsm26Z/1Y/1rzJ87RdU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tIG49vamh0IZmNxhYkUDQYZTPPQd1ntPvtFvXWcyKAP+GpgXaAvlmDgJhxRxWVk9X QzQez0bBmewLoWljdPF50LctePuQMbppbWKKUqyqtqHnuwQZs3pA0PBX3qi5Freijf p7aTsfFyi1IDNjrWN2aMtOPPnaMW/MAHjDqUnuDw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726148AbfAZSTP (ORCPT ); Sat, 26 Jan 2019 13:19:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:38752 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbfAZSTP (ORCPT ); Sat, 26 Jan 2019 13:19:15 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 20DC521872; Sat, 26 Jan 2019 18:19:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548526754; bh=vrsklQzt6XFm0nxumpI52ueEqsm26Z/1Y/1rzJ87RdU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KHZ6wH2P8z5IOorjgNRccXiESd8rxirGcRDQmc38O1u8Br2xtzpZCZN1Ah1wnpNkJ jRZvkcPKo6eAF+a5X/p6C3AFUprRAKU1z/AUFpVzQd7mZP4vnBRLeFmG0cUqeuD2Ib zL4n4JwAg1A3CBleP7Kx1XfV+jLflhVJ1HJ4y7Qc= Date: Sat, 26 Jan 2019 13:19:13 -0500 From: Sasha Levin To: Jack Pham Cc: Felipe Balbi , Greg Kroah-Hartman , stable@vger.kernel.org Subject: Re: [PATCH v2] usb: dwc3: gadget: Clear req->needs_extra_trb flag on cleanup Message-ID: <20190126181913.GF30183@sasha-vm> References: <20190110203955.10724-1-jackp@codeaurora.org> <20190116133553.B64662086D@mail.kernel.org> <20190126011816.GD23243@jackp-linux.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190126011816.GD23243@jackp-linux.qualcomm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Jan 25, 2019 at 05:18:16PM -0800, Jack Pham wrote: >Hi Sasha, > >On Wed, Jan 16, 2019 at 01:35:52PM +0000, Sasha Levin wrote: >> Hi, >> >> [This is an automated email] >> >> This commit has been processed because it contains a "Fixes:" tag, >> fixing commit: c6267a51639b usb: dwc3: gadget: align transfers to wMaxPacketSize. >> >> The bot has tested the following trees: v4.20.2, v4.19.15, v4.14.93. >> >> v4.20.2: Build failed! Errors: >> drivers/usb/dwc3/gadget.c:180:5: error: ‘struct dwc3_request’ has no member named ‘needs_extra_trb’ >> >> v4.19.15: Build failed! Errors: >> drivers/usb/dwc3/gadget.c:180:5: error: ‘struct dwc3_request’ has no member named ‘needs_extra_trb’ >> >> v4.14.93: Build failed! Errors: >> drivers/usb/dwc3/gadget.c:185:5: error: ‘struct dwc3_request’ has no member named ‘needs_extra_trb’ >> >> >> How should we proceed with this patch? > >I mentioned in my "cover" message of the patch that it needs a slight >rewrite for -stable since the 'needs_extra_trb' was only introduced in >v5.0-rc1. Now that my patch is in Linus's tree, I can send it separately >for -stable; I'll fix up the commit text slightly to refer to the >variables used before v5.0. Sorry, the bot is still very much dumb at this point and doesn't read cover letters :) Thank you! -- Thanks, Sasha