From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7E9FC282D7 for ; Wed, 30 Jan 2019 23:29:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75B97218D2 for ; Wed, 30 Jan 2019 23:29:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727068AbfA3X33 (ORCPT ); Wed, 30 Jan 2019 18:29:29 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:41984 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727056AbfA3X33 (ORCPT ); Wed, 30 Jan 2019 18:29:29 -0500 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 8DFB83C51; Wed, 30 Jan 2019 22:10:11 +0000 (UTC) Date: Wed, 30 Jan 2019 14:10:10 -0800 From: Andrew Morton To: Roman Gushchin Cc: "dairinin@gmail.com" , "dchinner@redhat.com" , "mhocko@kernel.org" , "mm-commits@vger.kernel.org" , "riel@surriel.com" , "stable@vger.kernel.org" Subject: Re: + revert-mm-dont-reclaim-inodes-with-many-attached-pages.patch added to -mm tree Message-Id: <20190130141010.cd666a48dd4f9970a48d4fde@linux-foundation.org> In-Reply-To: <20190130055420.GB2107@castle.DHCP.thefacebook.com> References: <20190130051009.vMQ1lujVl%akpm@linux-foundation.org> <20190130055420.GB2107@castle.DHCP.thefacebook.com> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, 30 Jan 2019 05:54:27 +0000 Roman Gushchin wrote: > I believe, that Rik's patch ( https://lkml.org/lkml/2019/1/28/1865 ) can make > a difference here, and might fix the regression. I'd give it a chance, before > reverting these two patches. Reverting will re-introduce the memcg-leak, which > is quite bad. Yup. I'll restore Rik's "mm, slab, vmscan: accumulate gradual pressure on small slabs" for next -mm.