From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gao Xiang <gaoxiang25@huawei.com>
Cc: gregkh@linuxfoundation.org,
linux-staging mailing list <devel@driverdev.osuosl.org>,
linux-erofs@lists.ozlabs.org, viro@ZenIV.linux.org.uk,
stable@vger.kernel.org
Subject: Re: patch "staging: erofs: keep corrupted fs from crashing kernel in" added to staging-linus
Date: Wed, 30 Jan 2019 23:00:35 +0300 [thread overview]
Message-ID: <20190130200035.GC2010@kadam> (raw)
In-Reply-To: <1e5bad91-3d65-c086-d42c-f87d642e3204@huawei.com>
On Wed, Jan 30, 2019 at 11:42:41PM +0800, Gao Xiang wrote:
>
>
> On 2019/1/30 23:05, Gao Xiang wrote:
> >
> > Hi Greg,
> >
> > Dan raised some suggestions to me. And I want to get some review ideas from Chao...
> > Current EROFS works good for the normal image, this patch is used for corrupted image only...
> >
> > Could you kindly drop this patch temporarily and I want to get them reviewed...
> > Not soon... Thanks!
>
> It seems this patch is the top of staging-linus...Could you kindly drop it and
> it is better to get "Reviewed-by:" tag for all EROFS bugfix patches from corresponding
> people (Chao, Dan, or Al if possible) first... Thank you very much!
>
> sorry to trouble you...
>
Greg has already reverted this but for future reference there wasn't
any need to panic or rush. It was just the kunmap_atomic() which only
affects corrupted filesystem on linux-next so it's not a big deal. The
rest was just my style grumblings and could have been addressed later or
even ignored.
regards,
dan carpenter
next prev parent reply other threads:[~2019-01-30 20:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 14:33 patch "staging: erofs: keep corrupted fs from crashing kernel in" added to staging-linus gregkh
2019-01-30 15:05 ` Gao Xiang
2019-01-30 15:42 ` Gao Xiang
2019-01-30 18:19 ` Greg KH
2019-01-30 20:00 ` Dan Carpenter [this message]
2019-01-30 22:57 ` Gao Xiang
-- strict thread matches above, loose matches on Subject: below --
2019-03-29 16:25 gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130200035.GC2010@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gaoxiang25@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=stable@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox