From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E61DCC282D8 for ; Fri, 1 Feb 2019 14:11:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A28512086C for ; Fri, 1 Feb 2019 14:11:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549030312; bh=CmxkhEQJKNGmXwFtX8yvXZJCZ2DgrHmiucVppsi9i0w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=SkJ6IGo/qkXPtbATczPYlqwyvKGSz3R+LJPIM9pt03xrg2iEU7DZxWS/lyTLS0YUo M+8qIfgtE8d0//Fxechyir+4J0ZhqFAB0htMmihx49/Mb8/rtIG0N0Ki4rO4gAmDNa w6iPSF25AlDiLzHNMGgrzSflWbn/QnDWp5c88YcY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727742AbfBAOLw (ORCPT ); Fri, 1 Feb 2019 09:11:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:34798 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726542AbfBAOLw (ORCPT ); Fri, 1 Feb 2019 09:11:52 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EA89D2086C; Fri, 1 Feb 2019 14:11:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549030311; bh=CmxkhEQJKNGmXwFtX8yvXZJCZ2DgrHmiucVppsi9i0w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OzuCkzpUxDfUuETB7ObJLfgFglUT/VJK5bSLL7aPsiHK2rwAhrqhzlM+UpVtYmNVK LtU+qL087tJg7m42lZkeMRHdT8Y66Mj/Wyn6HQ95sZev1sVxG4A7b6wixr7HN5Mxsd LowmGBOWwqkyp7iMTpjZa0A54a/I95gmo3fFgGAI= Date: Fri, 1 Feb 2019 09:11:49 -0500 From: Sasha Levin To: Pavel Shilovsky Cc: Greg KH , Stable Subject: Re: [PATCH] cifs: Always resolve hostname before reconnecting Message-ID: <20190201141149.GU3973@sasha-vm> References: <1548893250-48583-1-git-send-email-pshilov@microsoft.com> <20190131071600.GB4500@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Jan 31, 2019 at 10:37:54AM -0800, Pavel Shilovsky wrote: >ср, 30 янв. 2019 г. в 23:16, Greg KH : >> >> On Wed, Jan 30, 2019 at 04:07:30PM -0800, Pavel Shilovsky wrote: >> > Commit 28eb24ff75c5 ("cifs: Always resolve hostname before reconnecting"). >> > >> > In case a hostname resolves to a different IP address (e.g. long >> > running mounts), make sure to resolve it every time prior to calling >> > generic_ip_connect() in reconnect. >> > >> > This patch needs user space changes of cifs.upcall that set a timeout >> > value for the "dns_resolver" key. >> > >> > Suggested-by: Steve French >> > Signed-off-by: Paulo Alcantara >> > Signed-off-by: Steve French >> > Signed-off-by: Pavel Shilovsky >> > --- >> > fs/cifs/connect.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ >> > 1 file changed, 53 insertions(+) >> >> What stable kernel(s) is this to be applied to? >>\ > >All stable kernels that are under active maintenance may have the fix >if it applies clearly. Please let me know if it doesn't. So this wasn't actually tested against any of the stable kernels? Why not? Microsoft has a solid testsuite for it. -- Thanks, Sasha