From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01974C282D7 for ; Sat, 2 Feb 2019 11:28:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6E002080D for ; Sat, 2 Feb 2019 11:28:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549106933; bh=VoiOxjKyafmZ1j20UULkT4RXOn6Uc3JINxJ2G1+b9rg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rTMfXXjRfMnbL/ST+CLhzmLpZ5/mtmPX0jttNh4fbqe8pzZV1Vdrm4ee53Fyz0pHJ FlBMmY8iy6I7P6S2X9sz6tGdzsoVAACuQMlhY8vIwyIs/cldJa/jg/z2ED5sG+5a9v 3VvElGeSbLfitkfEowuSUryuo4Na1I6k/FakgeT4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726757AbfBBL2x (ORCPT ); Sat, 2 Feb 2019 06:28:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:53886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726678AbfBBL2w (ORCPT ); Sat, 2 Feb 2019 06:28:52 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE7842077B; Sat, 2 Feb 2019 11:28:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549106932; bh=VoiOxjKyafmZ1j20UULkT4RXOn6Uc3JINxJ2G1+b9rg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ODCAO139a9hUBc92rMKn/vnL0OKqJM7Q/ew3BypBbV3zS6AI2Xph9mJWJ68yF6sKA kTx/Knh6lX0mtQLHznJhgHAg2MbzLq+OESUq6U94URAr1AyZkBlax2shGJN/oj8na9 7HhJ7qWVAeDR1O0iUusc5L2lSrpso6881i+NWl7c= Date: Sat, 2 Feb 2019 12:28:50 +0100 From: Greg KH To: Jeff Kirsher Cc: stable@vger.kernel.org, Anirudh Venkataramanan , Tony Brelinski Subject: Re: [stable 4.19 2/4] ice: Updates to Tx scheduler code Message-ID: <20190202112850.GC31341@kroah.com> References: <20190201205029.11855-1-jeffrey.t.kirsher@intel.com> <20190201205029.11855-3-jeffrey.t.kirsher@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190201205029.11855-3-jeffrey.t.kirsher@intel.com> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Feb 01, 2019 at 12:50:27PM -0800, Jeff Kirsher wrote: > From: Anirudh Venkataramanan > > This is a backport of the mainline commit b36c598c999c ("ice: > Updates to Tx scheduler code"). This change is required for the > driver to work with the latest firmware. Without this patch, > the driver fails probe. Note, this is a big change. You can't have these systems just run the old firmware? The fact that you require a kernel change for newer firmware, isn't the best, you don't provide backwards compatibility somehow? I'm all for adding new device ids and the like to stable kernels, but to backport new functionality just to get newer hardware to work on older kernels, is not the goal of the LTS kernel trees. Why can't you just have users use 4.20 or newer? There shouldn't be anything keeping them from doing that and just updating to the latest stable release every 4 months or so, right? thanks, greg k-h