From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 941C6C282D7 for ; Sat, 2 Feb 2019 11:31:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E9C62081B for ; Sat, 2 Feb 2019 11:31:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549107107; bh=9SJHXSCFlZ/2TWgdCa0t6BeZyJ301bAuu0czaqEExYY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rnFqWmPWtVqh6qIcduECAgtJ9wSCo0fpyxhgib0TZlFTvIbJFOHHCfHVpNj4ttm4k 1v3hB8M/nICYaK9p9A2A8TqlmyIYkuY0lNHkEzzhBMFRJ+RnqBkxvOadG+g8tTBD4L 2zaXnadw9O49qX2/RNnMfzGRA+OhgXEodXH0ShfQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726761AbfBBLbq (ORCPT ); Sat, 2 Feb 2019 06:31:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:54796 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726711AbfBBLbq (ORCPT ); Sat, 2 Feb 2019 06:31:46 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3E3082081B; Sat, 2 Feb 2019 11:31:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549107105; bh=9SJHXSCFlZ/2TWgdCa0t6BeZyJ301bAuu0czaqEExYY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O661DG3rT7UPK5K6krwDTTvXybDRj4mZiac5elmHoc92tAO+BeEd8R4whYjyG2JKA LwKbcfD6L4+wpBzXHGhxC50gJB6Cy9H5oP+fi7P7qVqhZSu2f6IIUYkCGAGaRv42r1 E17E83eYAqxFxm0HQ+cb1CFLrUx2WSzmAWLG6IRg= Date: Sat, 2 Feb 2019 12:31:43 +0100 From: Greg KH To: Pavel Shilovsky Cc: Sasha Levin , Stable Subject: Re: [PATCH] cifs: Always resolve hostname before reconnecting Message-ID: <20190202113143.GD31341@kroah.com> References: <1548893250-48583-1-git-send-email-pshilov@microsoft.com> <20190131071600.GB4500@kroah.com> <20190201141149.GU3973@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Feb 01, 2019 at 12:17:21PM -0800, Pavel Shilovsky wrote: > пт, 1 февр. 2019 г. в 06:11, Sasha Levin : > > > > On Thu, Jan 31, 2019 at 10:37:54AM -0800, Pavel Shilovsky wrote: > > >ср, 30 янв. 2019 г. в 23:16, Greg KH : > > >> > > >> On Wed, Jan 30, 2019 at 04:07:30PM -0800, Pavel Shilovsky wrote: > > >> > Commit 28eb24ff75c5 ("cifs: Always resolve hostname before reconnecting"). > > >> > > > >> > In case a hostname resolves to a different IP address (e.g. long > > >> > running mounts), make sure to resolve it every time prior to calling > > >> > generic_ip_connect() in reconnect. > > >> > > > >> > This patch needs user space changes of cifs.upcall that set a timeout > > >> > value for the "dns_resolver" key. > > >> > > > >> > Suggested-by: Steve French > > >> > Signed-off-by: Paulo Alcantara > > >> > Signed-off-by: Steve French > > >> > Signed-off-by: Pavel Shilovsky > > >> > --- > > >> > fs/cifs/connect.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > > >> > 1 file changed, 53 insertions(+) > > >> > > >> What stable kernel(s) is this to be applied to? > > >>\ > > > > > >All stable kernels that are under active maintenance may have the fix > > >if it applies clearly. Please let me know if it doesn't. > > > > So this wasn't actually tested against any of the stable kernels? Why > > not? Microsoft has a solid testsuite for it. > > This was successfully tested on v4.4.y kernel. That's odd, as you generated this diff against the 4.20.y kernel. Oh well, I'll go queue this up, to all of the kernel trees, but be careful... greg k-h