From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1290BC282D7 for ; Sat, 2 Feb 2019 11:33:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC0542081B for ; Sat, 2 Feb 2019 11:33:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549107200; bh=FFhgc5DKeZHZaBT00+8qpdfFJ91JmsWxIAcMlxCUn6I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=STQPKRJ4Ho7t/JDnS0kKgaYoh/WjRmRrjjWrG3C1Uq2DAy/JBS/+126InaSTWYnGn uZ6YKKKlVyf2+MhgL8U+E3Q7eEnb/qEvSuM3wsNU5enHqEvdm27NeaTzX7to85Vw+C nhhuoKCn5L2RpiAyjQE2m1M14cDOEgJMB1XQh33E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726711AbfBBLdU (ORCPT ); Sat, 2 Feb 2019 06:33:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:55732 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726678AbfBBLdU (ORCPT ); Sat, 2 Feb 2019 06:33:20 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 48CBA2081B; Sat, 2 Feb 2019 11:33:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549107199; bh=FFhgc5DKeZHZaBT00+8qpdfFJ91JmsWxIAcMlxCUn6I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HczPAe+4EVv8KNurXOA6LMktZsAwByjoPQ2M15zKxfHvuWjSPPIZj7nGwVz+CajDe h0SudtjJU7KjSyt9AyTtRiqzmOBpHWtM8FYW7txdfw/pfQ1vZuAvWSN0TU7K0XmKFp DNdCZB7cNWFm6XUJg7QMcYbIU1SDnXuDWwHtVupk= Date: Sat, 2 Feb 2019 12:33:17 +0100 From: Greg KH To: Pavel Shilovsky Cc: stable@vger.kernel.org Subject: Re: [PATCH] cifs: Always resolve hostname before reconnecting Message-ID: <20190202113317.GE31341@kroah.com> References: <1548893250-48583-1-git-send-email-pshilov@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548893250-48583-1-git-send-email-pshilov@microsoft.com> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jan 30, 2019 at 04:07:30PM -0800, Pavel Shilovsky wrote: > Commit 28eb24ff75c5 ("cifs: Always resolve hostname before reconnecting"). > > In case a hostname resolves to a different IP address (e.g. long > running mounts), make sure to resolve it every time prior to calling > generic_ip_connect() in reconnect. > > This patch needs user space changes of cifs.upcall that set a timeout > value for the "dns_resolver" key. Wait, you are requiring userspace to upgrade tools to support this? And you think that will happen to all systems running older kernels? This really feels like a new feature being added, what bug is this fixing that requires it to be backported to all of the stable kernel trees? > > Suggested-by: Steve French > Signed-off-by: Paulo Alcantara > Signed-off-by: Steve French > Signed-off-by: Pavel Shilovsky At the very least, I would like the CIFS maintainer to ack this type of thing before accepting it, as it was not tagged for the stable kernels for some reason... thanks, greg k-h