* [PATCH v2 01/12] ARM: dts: da850: fix interrupt numbers for clocksource [not found] <20190204171757.32073-1-brgl@bgdev.pl> @ 2019-02-04 17:17 ` Bartosz Golaszewski 2019-02-05 1:18 ` David Lechner 0 siblings, 1 reply; 3+ messages in thread From: Bartosz Golaszewski @ 2019-02-04 17:17 UTC (permalink / raw) To: Sekhar Nori, Kevin Hilman, Daniel Lezcano, Rob Herring, Mark Rutland, Thomas Gleixner Cc: linux-arm-kernel, linux-kernel, devicetree, Bartosz Golaszewski, stable From: Bartosz Golaszewski <bgolaszewski@baylibre.com> The timer interrupts specified in commit 3652e2741f42 ("ARM: dts: da850: Add clocks") are wrong but since the current timer code hard-codes them, the bug was never spotted. This patch must go into stable since, once we introduce a proper clocksource driver, devices with buggy device tree will stop booting. Fixes: 3652e2741f42 ("ARM: dts: da850: Add clocks") Cc: stable@vger.kernel.org Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> --- arch/arm/boot/dts/da850.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index 47aa53ba6b92..559659b399d0 100644 --- a/arch/arm/boot/dts/da850.dtsi +++ b/arch/arm/boot/dts/da850.dtsi @@ -476,7 +476,7 @@ clocksource: timer@20000 { compatible = "ti,da830-timer"; reg = <0x20000 0x1000>; - interrupts = <12>, <13>; + interrupts = <21>, <22>; interrupt-names = "tint12", "tint34"; clocks = <&pll0_auxclk>; }; -- 2.20.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 01/12] ARM: dts: da850: fix interrupt numbers for clocksource 2019-02-04 17:17 ` [PATCH v2 01/12] ARM: dts: da850: fix interrupt numbers for clocksource Bartosz Golaszewski @ 2019-02-05 1:18 ` David Lechner 2019-02-08 13:09 ` Sekhar Nori 0 siblings, 1 reply; 3+ messages in thread From: David Lechner @ 2019-02-05 1:18 UTC (permalink / raw) To: Bartosz Golaszewski, Sekhar Nori, Kevin Hilman, Daniel Lezcano, Rob Herring, Mark Rutland, Thomas Gleixner Cc: devicetree, stable, linux-kernel, linux-arm-kernel, Bartosz Golaszewski On 2/4/19 11:17 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > The timer interrupts specified in commit 3652e2741f42 ("ARM: dts: > da850: Add clocks") are wrong but since the current timer code > hard-codes them, the bug was never spotted. > > This patch must go into stable since, once we introduce a proper > clocksource driver, devices with buggy device tree will stop booting. > > Fixes: 3652e2741f42 ("ARM: dts: da850: Add clocks") > Cc: stable@vger.kernel.org > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- Reviewed-by: David Lechner <david@lechnology.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 01/12] ARM: dts: da850: fix interrupt numbers for clocksource 2019-02-05 1:18 ` David Lechner @ 2019-02-08 13:09 ` Sekhar Nori 0 siblings, 0 replies; 3+ messages in thread From: Sekhar Nori @ 2019-02-08 13:09 UTC (permalink / raw) To: David Lechner, Bartosz Golaszewski, Kevin Hilman, Daniel Lezcano, Rob Herring, Mark Rutland, Thomas Gleixner Cc: devicetree, stable, linux-kernel, linux-arm-kernel, Bartosz Golaszewski On 05/02/19 6:48 AM, David Lechner wrote: > On 2/4/19 11:17 AM, Bartosz Golaszewski wrote: >> From: Bartosz Golaszewski <bgolaszewski@baylibre.com> >> >> The timer interrupts specified in commit 3652e2741f42 ("ARM: dts: >> da850: Add clocks") are wrong but since the current timer code >> hard-codes them, the bug was never spotted. >> >> This patch must go into stable since, once we introduce a proper >> clocksource driver, devices with buggy device tree will stop booting. >> >> Fixes: 3652e2741f42 ("ARM: dts: da850: Add clocks") >> Cc: stable@vger.kernel.org >> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> >> --- > > Reviewed-by: David Lechner <david@lechnology.com> This patch is already in ARM SoC. Should be soon in Linus's tree too. https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git/commit/?h=fixes&id=e3966a766865da7ced1dece663697861dd5cf103 Thanks, Sekhar ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-08 13:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190204171757.32073-1-brgl@bgdev.pl>
2019-02-04 17:17 ` [PATCH v2 01/12] ARM: dts: da850: fix interrupt numbers for clocksource Bartosz Golaszewski
2019-02-05 1:18 ` David Lechner
2019-02-08 13:09 ` Sekhar Nori
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox