From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F566C282C4 for ; Mon, 4 Feb 2019 23:32:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 196E120821 for ; Mon, 4 Feb 2019 23:32:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="T7w6Jsa+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726978AbfBDXcA (ORCPT ); Mon, 4 Feb 2019 18:32:00 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:43002 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726471AbfBDXcA (ORCPT ); Mon, 4 Feb 2019 18:32:00 -0500 Received: by mail-pg1-f196.google.com with SMTP id d72so610773pga.9 for ; Mon, 04 Feb 2019 15:31:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YOWkI04pHS0FvuoxLkEtlijY7L71rnyQ7wBQ8dYXGP8=; b=T7w6Jsa+WBFj2gJ50l76pyQs8kBqUu8UNvGYN0OwDCmLYL9FFY4HUiDBZ+ophT7tB/ 43pbRajC3lGPERdmT6iMGRPHiZ+UppW/xD4EHx7QpFCv//zerK9E5nESXaLFn2ocDZ42 +3b0ngQTZLSAMXluK6N47znEOqvdaKc8cT/JqVklrVh7iZXfPkQP+l9QVm2JHi1oSY6t pTkw2jaRijyzmvdQbLwda9IU3yysniyEI4Au2/SJCY8jUgRtx+DBWLCfUFl/zIpz4lW0 U61OYPf+Hc+VuGSGcOtpHPjYs9GZ2pR7VS3IWGHRvwUcRX+WgJfYkWV8CkbVNXTUZa85 XXaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YOWkI04pHS0FvuoxLkEtlijY7L71rnyQ7wBQ8dYXGP8=; b=N71I0jPZLL36PPgVzzHvef0dsYKRqwGwHKUHSP/Svn9zGVdcVLAXjF8ZdbofdKxf/H SuBTb/uxNNcqOfre+UGsm4xbJYd3it/V9/u4st1JqU8tcBUEbGgq0fIIVJANk1OrOCeI 9jpgM9v0LMgKAxAakPY8Mnm0SByUsIPqLvdZ3BHlbwJNH4qQmNDhTJ5zjG1OU1bXfnj8 aU5M8VqvwZOO+tXkcZv4YiRrsaMHjOy5A4j1im1DO/ZROafSWkfpuNsQRDHFrmMTldR0 RUjwm5PQEnvMkW90MyHkcXKNYmjlf6Mpmi3B+NtXQOQlFoUoeNupDFFgZCfTw0jFSqLU 9PlA== X-Gm-Message-State: AHQUAubet80qJ2uPhDrXgz4GAECKmu8rN12HXtGvCwsmMZVTFzBMbIQF WYZspxL/8affGgj8eN9WPQJPJA== X-Google-Smtp-Source: AHgI3Ib2E4o8UR/ORB4Lvpg6tOKq+ZwibNgeoCwyblGUs/gl1xzil1TIer3WTFkkAvZ506MvVmXGgQ== X-Received: by 2002:a63:1142:: with SMTP id 2mr1775566pgr.39.1549323119533; Mon, 04 Feb 2019 15:31:59 -0800 (PST) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id e16sm1397173pfn.46.2019.02.04.15.31.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Feb 2019 15:31:59 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1gqniY-0003so-AV; Mon, 04 Feb 2019 16:31:58 -0700 Date: Mon, 4 Feb 2019 16:31:58 -0700 From: Jason Gunthorpe To: Bart Van Assche Cc: Doug Ledford , linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, Sergey Gorenko , Max Gurtovoy , Laurence Oberman , stable@vger.kernel.org Subject: Re: [PATCH v2] RDMA/srp: Rework SCSI device reset handling Message-ID: <20190204233158.GA14895@ziepe.ca> References: <20190130220555.8949-1-bvanassche@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190130220555.8949-1-bvanassche@acm.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jan 30, 2019 at 02:05:55PM -0800, Bart Van Assche wrote: > Since .scsi_done() must only be called after scsi_queue_rq() has > finished, make sure that the SRP initiator driver does not call > .scsi_done() while scsi_queue_rq() is in progress. Although > invoking sg_reset -d while I/O is in progress works fine with kernel > v4.20 and before, that is not the case with kernel v5.0-rc1. This > patch avoids that the following crash is triggered with kernel > v5.0-rc1: > > BUG: unable to handle kernel NULL pointer dereference at 0000000000000138 > CPU: 0 PID: 360 Comm: kworker/0:1H Tainted: G B 5.0.0-rc1-dbg+ #1 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1 04/01/2014 > Workqueue: kblockd blk_mq_run_work_fn > RIP: 0010:blk_mq_dispatch_rq_list+0x116/0xb10 > Call Trace: > blk_mq_sched_dispatch_requests+0x2f7/0x300 > __blk_mq_run_hw_queue+0xd6/0x180 > blk_mq_run_work_fn+0x27/0x30 > process_one_work+0x4f1/0xa20 > worker_thread+0x67/0x5b0 > kthread+0x1cf/0x1f0 > ret_from_fork+0x24/0x30 > > Cc: Sergey Gorenko > Cc: Max Gurtovoy > Cc: Laurence Oberman > Cc: > Fixes: 94a9174c630c ("IB/srp: reduce lock coverage of command completion") # v2.6.38 > Signed-off-by: Bart Van Assche > --- > > Changes compared to v1: left out the code that waits until in-progress requests > have finished. Applied to for-rc Thanks, Jason