From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 481F4C282CC for ; Tue, 5 Feb 2019 15:08:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 048DD217D6 for ; Tue, 5 Feb 2019 15:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549379285; bh=jwQAqMvaJ35MoMzbbEmMS2POWO3ZRI9zvR4hAeESv2M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=cSKXdMFb0oGGU7Hya1ci5hU+IRBouxVYae753423Pb8JDL1EE4JY4ShXlm7AwfAym Kyf9wDtpGOZUSgJyF+uMQAZVOg4p2Le5wKXzy4OrDZ7MaWoRxyI3gKjQWtpA1XFrtH +F16HLUMYD5cotl558vxJzkOIrTAwLML8orJloPI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729611AbfBEPHW (ORCPT ); Tue, 5 Feb 2019 10:07:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:42160 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726646AbfBEPHV (ORCPT ); Tue, 5 Feb 2019 10:07:21 -0500 Received: from quaco.ghostprotocols.net (unknown [190.15.121.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE58E2184B; Tue, 5 Feb 2019 15:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549379240; bh=jwQAqMvaJ35MoMzbbEmMS2POWO3ZRI9zvR4hAeESv2M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Knvjw8qFawGk53gH2H/zwvQArCa24KNKf+n74P+SnUYpRPALg1EC8f6jfkuVEmZ4F 0JP4a0ESj9DtNpT1y0W4qGHVBCsKQzwWdENWUCbX4uTt2KmmfadkzZMsdZRdySB0uV BQ5wlSNIHyHjYgXG+h+ksvWVJDuEmP87mUKSsTzg= From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, "Gustavo A. R. Silva" , Jiri Olsa , Alexander Shishkin , Namhyung Kim , Peter Zijlstra , stable@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH 1/8] perf tests evsel-tp-sched: Fix bitwise operator Date: Tue, 5 Feb 2019 12:07:01 -0300 Message-Id: <20190205150708.9012-2-acme@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190205150708.9012-1-acme@kernel.org> References: <20190205150708.9012-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: "Gustavo A. R. Silva" Notice that the use of the bitwise OR operator '|' always leads to true in this particular case, which seems a bit suspicious due to the context in which this expression is being used. Fix this by using bitwise AND operator '&' instead. This bug was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva Acked-by: Jiri Olsa Cc: Alexander Shishkin Cc: Namhyung Kim Cc: Peter Zijlstra Cc: stable@vger.kernel.org Fixes: 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint format fields") Link: http://lkml.kernel.org/r/20190122233439.GA5868@embeddedor Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/tests/evsel-tp-sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/tests/evsel-tp-sched.c b/tools/perf/tests/evsel-tp-sched.c index 5f8501c68da4..5cbba70bcdd0 100644 --- a/tools/perf/tests/evsel-tp-sched.c +++ b/tools/perf/tests/evsel-tp-sched.c @@ -17,7 +17,7 @@ static int perf_evsel__test_field(struct perf_evsel *evsel, const char *name, return -1; } - is_signed = !!(field->flags | TEP_FIELD_IS_SIGNED); + is_signed = !!(field->flags & TEP_FIELD_IS_SIGNED); if (should_be_signed && !is_signed) { pr_debug("%s: \"%s\" signedness(%d) is wrong, should be %d\n", evsel->name, name, is_signed, should_be_signed); -- 2.20.1