From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BD88C169C4 for ; Wed, 6 Feb 2019 22:00:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E98C218B0 for ; Wed, 6 Feb 2019 22:00:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726393AbfBFWAC (ORCPT ); Wed, 6 Feb 2019 17:00:02 -0500 Received: from ipmail03.adl6.internode.on.net ([150.101.137.143]:49899 "EHLO ipmail03.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726037AbfBFWAB (ORCPT ); Wed, 6 Feb 2019 17:00:01 -0500 X-Greylist: delayed 302 seconds by postgrey-1.27 at vger.kernel.org; Wed, 06 Feb 2019 17:00:00 EST Received: from ppp59-167-129-252.static.internode.on.net (HELO dastard) ([59.167.129.252]) by ipmail03.adl6.internode.on.net with ESMTP; 07 Feb 2019 08:24:56 +1030 Received: from dave by dastard with local (Exim 4.80) (envelope-from ) id 1grV9i-0003Mz-VZ; Thu, 07 Feb 2019 08:54:55 +1100 Date: Thu, 7 Feb 2019 08:54:54 +1100 From: Dave Chinner To: Sasha Levin Cc: Luis Chamberlain , linux-xfs@vger.kernel.org, gregkh@linuxfoundation.org, Alexander.Levin@microsoft.com, stable@vger.kernel.org, amir73il@gmail.com, hch@infradead.org Subject: Re: [PATCH v2 00/10] xfs: stable fixes for v4.19.y Message-ID: <20190206215454.GG14116@dastard> References: <20190204165427.23607-1-mcgrof@kernel.org> <20190205220655.GF14116@dastard> <20190206040559.GA4119@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190206040559.GA4119@sasha-vm> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Feb 05, 2019 at 11:05:59PM -0500, Sasha Levin wrote: > On Wed, Feb 06, 2019 at 09:06:55AM +1100, Dave Chinner wrote: > >On Mon, Feb 04, 2019 at 08:54:17AM -0800, Luis Chamberlain wrote: > >>Kernel stable team, > >> > >>here is a v2 respin of my XFS stable patches for v4.19.y. The only > >>change in this series is adding the upstream commit to the commit log, > >>and I've now also Cc'd stable@vger.kernel.org as well. No other issues > >>were spotted or raised with this series. > >> > >>Reviews, questions, or rants are greatly appreciated. > > > >Test results? > > > >The set of changes look fine themselves, but as always, the proof is > >in the testing... > > Luis noted on v1 that it passes through his oscheck test suite, and I > noted that I haven't seen any regression with the xfstests scripts I > have. > > What sort of data are you looking for beyond "we didn't see a > regression"? Nothing special, just a summary of what was tested so we have some visibility of whether the testing covered the proposed changes sufficiently. i.e. something like: Patchset was run through ltp and the fstests "auto" group with the following configs: - mkfs/mount defaults - -m reflink=1,rmapbt=1 - -b size=1k - -m crc=0 .... No new regressions were reported. Really, all I'm looking for is a bit more context for the review process - nobody remembers what configs other people test. However, it's important in reviewing a backport to know whether a backport to a fix, say, a bug in the rmap code actually got exercised by the tests on an rmap enabled filesystem... Cheers, Dave. -- Dave Chinner david@fromorbit.com