From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4A73C282C2 for ; Thu, 7 Feb 2019 15:52:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D88F21904 for ; Thu, 7 Feb 2019 15:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549554737; bh=jjCM6+qA55m0WFVTFKKxUoKxMdvwXVuMJl89IJzDh+g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=eUKVKi1Fru/j01nokc0wnvQu6t5vnvtLm/48cgUIZlq3RsR1BEf+PnzgjdHWAxSvo fe5welE/c1pMDWCR1JEe6IN7peLPAHlrH3wFnZZEKZ5f1W34kVeI0iEprk5opzW8ve KFq0813TpDV7eMHJqmMB0n0NbWWD0Pcqq4uJkBtg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726319AbfBGPwR (ORCPT ); Thu, 7 Feb 2019 10:52:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:41352 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbfBGPwR (ORCPT ); Thu, 7 Feb 2019 10:52:17 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8C1D21872; Thu, 7 Feb 2019 15:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549554736; bh=jjCM6+qA55m0WFVTFKKxUoKxMdvwXVuMJl89IJzDh+g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TypzgtG0P8ksQLUoCZzoiScPI98mdgjc2YF8ijLeZgAgLvzOC20aLUBgzoR34p798 IA74jVQvFk4hc9DCWdNBgD8D9C7MluToTdse2tV+dfpOl2fFG2gAqtbnZQskXBnhtU /P23GXKiUCJ1xcV58+Kld6gzFV+czrts61XqiNVc= Date: Thu, 7 Feb 2019 16:52:13 +0100 From: "gregkh@linuxfoundation.org" To: Alexey Brodkin Cc: "David.Laight@ACULAB.COM" , "geert@linux-m68k.org" , "peterz@infradead.org" , "stable@vger.kernel.org" , "tglx@linutronix.de" , "will.deacon@arm.com" , Vineet Gupta , "linux-snps-arc@lists.infradead.org" Subject: Re: patch "devres: Align data[] to ARCH_KMALLOC_MINALIGN" added to driver-core-linus Message-ID: <20190207155213.GC7164@kroah.com> References: <1541965277161164@kroah.com> <4881796E12491D4BB15146FE0209CE64681D5C43@DE02WEMBXB.internal.synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4881796E12491D4BB15146FE0209CE64681D5C43@DE02WEMBXB.internal.synopsys.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Feb 07, 2019 at 01:12:43PM +0000, Alexey Brodkin wrote: > Hi Greg, > > > -----Original Message----- > > From: gregkh@linuxfoundation.org > > Sent: Sunday, November 11, 2018 10:41 PM > > To: alexey.brodkin@synopsys.com; David.Laight@ACULAB.COM; alexey.brodkin@synopsys.com; geert@linux- > > m68k.org; greg@kroah.com; gregkh@linuxfoundation.org; peterz@infradead.org; stable@vger.kernel.org; > > tglx@linutronix.de; vineet.gupta1@synopsys.com; will.deacon@arm.com > > Subject: patch "devres: Align data[] to ARCH_KMALLOC_MINALIGN" added to driver-core-linus > > > > > > This is a note to let you know that I've just added the patch titled > > > > devres: Align data[] to ARCH_KMALLOC_MINALIGN > > > > to my driver-core git tree which can be found at > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git > > in the driver-core-linus branch. > > > > The patch will show up in the next release of the linux-next tree > > (usually sometime within the next 24 hours during the week.) > > > > The patch will hopefully also be merged in Linus's tree for the > > next -rc kernel release. > > > > If you have any questions about this process, please let me know. > > > > > > From a66d972465d15b1d89281258805eb8b47d66bd36 Mon Sep 17 00:00:00 2001 > > From: Alexey Brodkin > > Date: Wed, 31 Oct 2018 18:25:47 +0300 > > Subject: devres: Align data[] to ARCH_KMALLOC_MINALIGN > > > > Initially we bumped into problem with 32-bit aligned atomic64_t > > on ARC, see [1]. And then during quite lengthly discussion Peter Z. > > mentioned ARCH_KMALLOC_MINALIGN which IMHO makes perfect sense. > > If allocation is done by plain kmalloc() obtained buffer will be > > ARCH_KMALLOC_MINALIGN aligned and then why buffer obtained via > > devm_kmalloc() should have any other alignment? > > [snip] > > > Cc: # 4.8+ > > Signed-off-by: Greg Kroah-Hartman > > I noticed this patch was not only merged in Linus' tree quite some time ago > but it was as well back-ported to v4.20, see [1] but for some reason there's > no backport to either LTS kernel (v4.19, v4.14 and v4.9). > > Is there any problem with this patch and LTS kernels or may we have this one > applied? > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-4.20.y&id=a66d972465d15b1d89281258805eb8b47d66bd36 Ah, I was waiting to see if you would notice :) See this question from Linus about this patch: https://lore.kernel.org/lkml/CAHk-=wj3Q7CkMQYwfZSsqUTqkEhNwVGrRbCwe7AVJ70S8i5sWw@mail.gmail.com/ I figured that you all did this for a good reason, and wasting that much space was going to be ok. But, I wanted to be sure, so if you never noticed it, I figured it was not that pressing of an issue. Anyway, is this really needed to be backported? thanks, greg k-h